Fix minimalnumberofconnections#2718
Merged
MMathisLab merged 4 commits intoDeepLabCut:mainfrom Sep 6, 2024
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've noticed that convert_detections_to_tracklets always uses the default value for min_n_links. Based on the comment on inference_cfg.yaml sample, the value at minimalnumberofconnctions should be used instead.
DeepLabCut/deeplabcut/inference_cfg.yaml
Lines 17 to 18 in dd0ef5a
This pull request makes the following change.
minimalnumberofconnectionsfrominference_cfg.yamland use it asmin_n_linkswhen creating the Assembler.