Bug fixes: find_closest_neighbors + ellipse tracking#2709
Merged
MMathisLab merged 2 commits intopytorch_dlcfrom Aug 10, 2024
Merged
Bug fixes: find_closest_neighbors + ellipse tracking#2709MMathisLab merged 2 commits intopytorch_dlcfrom
find_closest_neighbors + ellipse tracking#2709MMathisLab merged 2 commits intopytorch_dlcfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request makes two bug fixes:
In
deeplabcut/core/crossvalutils.py-find_closest_neighborsn(the size of the input data) for missing nieghbors ("Missing neighbors are indicated withself.n."). This wasn't taken into account, so this value could be returned in the index list, leading to an out-of-bounds error.In
deeplabcut/core/trackingutils.py-calc_similarity_with