Conversation
…arge COCO datasets
MMathisLab
approved these changes
Jul 19, 2024
Member
MMathisLab
left a comment
There was a problem hiding this comment.
lgtm, although I did not test
MMathisLab
approved these changes
Jul 19, 2024
Member
MMathisLab
left a comment
There was a problem hiding this comment.
but see suggested changes to docstrings
MMathisLab
approved these changes
Jul 19, 2024
Member
MMathisLab
left a comment
There was a problem hiding this comment.
maybe in main docs we need to add information about these new metrics as well @n-poulsen
2 tasks
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Evaluation refactor
Improvements to the evaluation code, as well as new tests to ensure that mAP scores match the pycocotools implementation.
Change list:
deeplabcut/core/metricsfolder (as metrics are computed withnumpy)compute_detection_rmseto compute "detection" RMSE, matching the DeepLabCut 2.X implementationValueError: matrix contains invalid numeric entries#2631