Fix interp kwarg in imresize function.#2374
Merged
MMathisLab merged 3 commits intoDeepLabCut:mainfrom Sep 14, 2023
Merged
Conversation
Member
|
@Tetra-quark thanks! also if of use, check out the notebooks that go with our Primer, https://github.com/DeepLabCut/Primer-MotionCapture, as they plot the augmentations |
n-poulsen
approved these changes
Sep 14, 2023
Contributor
n-poulsen
left a comment
n-poulsen
left a comment
There was a problem hiding this comment.
Looks good to me! Thanks for the help!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed the
imresizefunction had usages that referred to the kwarginterpbut the actual definition of the function had a different nameinterpolationmethod.I then noticed that the args were provided as strings but the underlying OpenCV method actually takes an enum.
I applied the necessary corrections although I have not tested the scripts myself. I was interested in visualizing the augmentations without actively training but I wrote my own script for that.