Use QFrame.Shape.StyledPanel instead of QFrame.StyledPanel#2243
Merged
MMathisLab merged 2 commits intoDeepLabCut:mainfrom May 25, 2023
Merged
Use QFrame.Shape.StyledPanel instead of QFrame.StyledPanel#2243MMathisLab merged 2 commits intoDeepLabCut:mainfrom
MMathisLab merged 2 commits intoDeepLabCut:mainfrom
Conversation
I think this helps with qtpy which doesn't provide a few of the "conveniences" of PySide6. I understand if you might not care, but I do think this helps provide a bit of compatibility with a few other environments. Thank you for considering this
Contributor
Author
|
I'm not sure if this might be the cause but on conda-forge we have newer versons of pyside6 beyond 6.3 |
Contributor
Author
|
in an other change, i'm suggesting to ensure that setLineWidth corresponds to integers: https://doc.qt.io/qt-6/qframe.html#lineWidth-prop i would have made a distinct PR but it would have created too many merge conflicts. |
MMathisLab
approved these changes
May 25, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think this helps with qtpy which doesn't provide a few of the "conveniences" of PySide6.
I understand if you might not care, but I do think this helps provide a bit of compatibility with a few other environments.
Thank you for considering this