codespell: config, action and a few typos fixed#2217
Merged
MMathisLab merged 7 commits intoDeepLabCut:mainfrom May 1, 2023
Merged
codespell: config, action and a few typos fixed#2217MMathisLab merged 7 commits intoDeepLabCut:mainfrom
MMathisLab merged 7 commits intoDeepLabCut:mainfrom
Conversation
I think that numpy.ndarray was intended to me listed as type, and make variable more explicit to not use typo-close mot
=== Do not change lines below ===
{
"chain": [],
"cmd": "codespell -w",
"exit": 0,
"extra_inputs": [],
"inputs": [],
"outputs": [],
"pwd": "."
}
^^^ Do not change lines above ^^^
Contributor
|
Hey @yarikoptic, this is cool, thanks a lot! Just one question though: if a typo is detected when the GitHub action runs, does the workflow entirely stop or does codespell auto-fix it? If it doesn't, I'm thinking that maybe we should have a deeplabcut[dev] that installs e.g. codespell, black, pytest. |
Contributor
Author
|
Only fails/stops so author could either fix or ignore it. Many projects use pre-commit to automate use of those tools on developer side. Black etc could be added like we have eg in https://github.com/dandi/dandi-cli/blob/master/.pre-commit-config.yaml . But that should be separate/complimentary to this PR IMHO. |
AlexEMG
approved these changes
Apr 28, 2023
Member
|
can merge after checks pass, thanks for the contribution @yarikoptic |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To help keeping DeepLabCut typos free. Individual commits might have more reasoning etc.