Skip to content

Fix ZeroDivisionError during calibration #1819

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MMathisLab merged 1 commit into from
May 3, 2022
Merged

Fix ZeroDivisionError during calibration #1819

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions deeplabcut/pose_estimation_tensorflow/lib/inferenceutils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -316,15 +316,15 @@ def calc_assembly_mahalanobis_dist(
if self._kde is None:
raise ValueError("Assembler should be calibrated first with training data.")

if not len(assembly):
# Distance is undefined if the assembly is empty
dists = assembly.calc_pairwise_distances() - self._kde.mean
mask = np.isnan(dists)
# Distance is undefined if the assembly is empty
if not len(assembly) or mask.all():
if return_proba:
return np.inf, 0
return np.inf

dists = assembly.calc_pairwise_distances() - self._kde.mean
mask = np.isnan(dists)
if mask.any() and nan_policy == "little":
if nan_policy == "little":
inds = np.flatnonzero(~mask)
dists = dists[inds]
inv_cov = self._kde.inv_cov[np.ix_(inds, inds)]
Expand Down
6 changes: 6 additions & 0 deletions tests/test_inferenceutils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -293,6 +293,12 @@ def test_assembler_calibration(real_assemblies):
p = ass.calc_link_probability(link)
assert np.isclose(p, 0.993, atol=1e-3)

# Test empty assembly
assembly.data[:, :2] = np.nan
mahal, proba = ass.calc_assembly_mahalanobis_dist(assembly, return_proba=True)
assert np.isinf(mahal)
assert proba == 0


def test_find_outlier_assemblies(real_assemblies):
assert len(inferenceutils.find_outlier_assemblies(real_assemblies)) == 13