Skip to content

Fix ZeroDivisionError during calibration - #1819

Merged
MMathisLab merged 1 commit into
masterfrom
fix_1818
May 3, 2022
Merged

Fix ZeroDivisionError during calibration#1819
MMathisLab merged 1 commit into
masterfrom
fix_1818

Conversation

@jeylau

@jeylau jeylau commented May 3, 2022

Copy link
Copy Markdown
Contributor

We now properly catch assemblies that are either empty or contain NaN coordinates.
I improved the unit test too.

Fixes #1818

@jeylau jeylau added the bug fix! fix for a real buggy one... label May 3, 2022
@jeylau
jeylau requested a review from MMathisLab May 3, 2022 06:55
@MMathisLab
MMathisLab merged commit 188497a into master May 3, 2022
@BinZJU

BinZJU commented May 5, 2022

Copy link
Copy Markdown

Sorry to bother you again.Just to make sure. I saw 9 failed checks on this page. Does it mean the bug [1818] has not been totally fixed?Many thanks.

@jeylau

jeylau commented May 5, 2022

Copy link
Copy Markdown
Contributor Author

Hey @BinZJU, no worries, it's just that the patch got merged before I had the chance to fix the unit tests (which I did shortly after with cd97518). It doesn't affect your experience though, it is only some automatic tests that are run on our side :)

@BinZJU

BinZJU commented May 5, 2022

Copy link
Copy Markdown

Thank you. Also, thanks for the help from MMathisLab.
Actually, I followed these steps. But I still can't get the video analyzed as expected.

  1. Open the Anaconda Prompt (Admin)
  2. conda activate DEEPLABCUT
  3. pip install git+https://github.com/DeepLabCut/DeepLabCut.git@fix_1818 (OR pip install git+https://github.com/DeepLabCut/DeepLabCut.git, I've tried both)
  4. python -m deeplabcut
  5. Load the existing project
  6. Analyze videos (checked Calibrate animal assembly and Assemble using animal identity )
  7. ZeroDivisionError is present……

Do I need to totally remove DeepLabCut and then reinstall it?
I apologize for any inconvenience and thank you for your time.
Snipaste_2022-05-05_22-31-39

@BinZJU

BinZJU commented May 7, 2022

Copy link
Copy Markdown

Hey @BinZJU, no worries, it's just that the patch got merged before I had the chance to fix the unit tests (which I did shortly after with cd97518). It doesn't affect your experience though, it is only some automatic tests that are run on our side :)

Hey, Jeylau @jeylau !Another question, after reinstalling the DCL with pip install git+https://github.com/DeepLabCut/DeepLabCut.git@fix_1818, can I still use DLC with GUI? In other words, do I have to use DLC without GUI in order to get the ZeroDivisionError bug fixed?
Thank you so much!

@jeylau

jeylau commented May 7, 2022

Copy link
Copy Markdown
Contributor Author

Hey @BinZJU, the version you installed is DLC 2.2.1 + the small extra fix. So you can use it normally, either with or without GUI 😊

@BinZJU

BinZJU commented May 7, 2022

Copy link
Copy Markdown

Thanks! DLC really helps! And it finally works. Just to let you know, I created a new conda env with Python=3.7 to install the DLC2.2.1+1818 fix, then everything goes well. I don't know what's wrong with the previous env. The only difference is that it is based on python 3.8.

@jeylau
jeylau deleted the fix_1818 branch July 29, 2022 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug fix! fix for a real buggy one...

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ZeroDivisionError when analyze videos

3 participants