fix(network): retry connection-lost requests only for idempotent methods - #446
Merged
MaatheusGois merged 1 commit intoSep 2, 2026
Merged
Conversation
CustomHTTPProtocol silently re-issued any request (including POST) on cfurlErrorNetworkConnectionLost; duplicating non-idempotent requests can repeat server-side effects. Retry now only GET/HEAD/OPTIONS/TRACE.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CustomHTTPProtocolsilently re-issues the original request oncfurlErrorNetworkConnectionLostwhen no data was received — for any HTTP method. Re-issuing non-idempotent requests (POST/PUT/PATCH/DELETE) can duplicate server-side effects: a payment/order POST whose connection drops after reaching the server gets sent twice, and the app never sees the first attempt. Apple's URL loading system deliberately never auto-retries POST on connection-lost for this reason.This limits the silent retry to idempotent methods (GET/HEAD/OPTIONS/TRACE).
Type of change
Test plan
Manual test steps
networkConnectionLostbefore any data arrives.Checklist