Chore/sync upstream - #445
Closed
FreddieCarre wants to merge 13 commits into
Closed
FreddieCarre wants to merge 13 commits into
FreddieCarre wants to merge 13 commits into
Conversation
🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
…eenshot-for-leakdetector-in-debugswift [YAP-1557] Disable screenshots on leakdetector
…eenshot-for-leakdetector-in-debugswift-fix Disable screenshot for lvcdCheckForMemoryLeak
[YAP-5708] Restore native HTTP detail copying
# Conflicts: # DebugSwift/Sources/Features/Network/DataSource/HTTP.Datasource.swift # DebugSwift/Sources/Features/Network/Details/Network.Controller.Detail.swift # DebugSwift/Sources/Features/Performance/Helpers/Performance.LeakDetector.swift
GraphQL transports failures inside an HTTP 200, so a failed operation previously looked successful in the request list. This surfaces the response's errors array as a first-class row state while keeping the real HTTP status visible: - HttpModel gains graphQLErrors ([HttpGraphQLError]: message/path/code) and isSuccess now accounts for them, so the success rate and the errors-only filter pick GraphQL failures up automatically. - GraphQLInspector.extractErrors parses the errors array; the adapter classifies models centrally in HttpDatasource.addHttpRequest, so any capture path (URLProtocol or an app-side bridge) gets the state. - The list cell turns the left rail red, shows a labelled GRAPHQL ERROR badge below the (still code-coloured) HTTP status, and adds a red one-line subtitle: the error message, or "GraphQL errors (N)". - The detail view leads with a GRAPHQL ERRORS (N) section exposing all messages, paths, and extension codes. - The stats summary gains an Errors tile that doubles as a quick errors-only filter toggle. Also removes NetworkSelectableTextViewTests, which tested the pre-sync detail UI (NetworkTableViewCellDetail/copySection) removed by the upstream redesign that now provides native copying. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.