Tweaks 'n fixes for the leak detector - #439
Merged
Merged
Conversation
- added fallbacks in case super.viewDidLoad() was not called - better system for preventing double/simultaneous checking - fixed the deallocator being kept alive while waiting for the delay - added a check to UILayoutContainerView check to prevent getting certain unnecessary warnings - tweaked the warning message string (mainly for navigation/tabcontroller) - after a leaked VC deinits the leak detector is triggered again to check if all children are gone too - rewrote deallocator deinit code because it was totally broken, causing deinit triggers to fail, deinits now properly show up again in the leaks list with the green icon - updated outdated README info
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I just released LeakedViewControllerDetector 1.4.0. I applied the same fixes here, where applicable. I fixed some specific issues here while I was at it.
added fallbacks in case super.viewDidLoad() was not called
better system for preventing double/simultaneous checking
fixed the deallocator being kept alive while waiting for the delay
added a check to UILayoutContainerView check to prevent getting certain unnecessary warnings
tweaked the warning message string (mainly for navigation/tabcontroller)
after a leaked VC deinits the leak detector is triggered again to check if all children are gone too
rewrote deallocator deinit code because it was totally broken, causing deinit triggers to fail, deinits now properly show up again in the leaks list with the green icon
updated outdated README info
Type of change
Test plan
Manual test steps
Checklist