Skip to content

Conversation

@lucaswerkmeister
Copy link
Member

The required PHP version was bumped in 71a308f, and we stopped testing HHVM in a76ffa8.

The required PHP version was bumped in 71a308f, and we stopped
testing HHVM in a76ffa8.
Copy link
Member

@JeroenDeDauw JeroenDeDauw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a bit premature - the current README is correct for the latest release

Could do something along these lines if you really want to add the info already: https://github.com/DataValues/Geo/#requirements

@lucaswerkmeister
Copy link
Member Author

No PHP version older than PHP 7.2 is supported by PHP itself: https://www.php.net/supported-versions.php – so even before the 3.0 release, I don’t see much value in stating support for PHP 5.5.

But what I really want is a 3.0.0 release (for T260915), so if you think this should be done together with the release, that’s fine by me as long as the release happens soon.

@JeroenDeDauw
Copy link
Member

Right ok - looks like we finally have some incentive to make a release.

This might well be the last major release for these components ever, so please have a look at the other libs linked here to see if you want something else changed as well: #58

JeroenDeDauw added a commit that referenced this pull request Jan 19, 2021
Fixes #58
Fixes #59
@addshore addshore closed this in 63dee28 Jan 19, 2021
@JeroenDeDauw JeroenDeDauw deleted the requirements branch January 19, 2021 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants