-
-
Notifications
You must be signed in to change notification settings - Fork 8
2.0.0 release #23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2.0.0 release #23
Conversation
README.md
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think the ~ character gives enough information. A common way to say "PHP 5.3 or later" is "PHP 5.3+". I have never seen the ~ outside of composer.json files and still find it confusing every time I see it. Please be bold.
|
|
|
Indeed, these changes are minor. I do not think we need this release. Neither do I think it hurts. I'm thinking that nothing much more significant is likely to happen though. Which would mean these minor changes where a waste of time for all intents and purposes. |
README.md
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update this date before doing the actual release (a.k.a. tag).
|
I would merge this and do the release, but would like to know if we can agree on #25 possibly becoming part of this 2.0.0 release? |
|
Fine by me |
a578c86 to
9f1cc88
Compare
|
I rebased this again and updated the release notes to mention everything that changed since the last release. I also realized we never released 1.0.1. If somebody is willing to merge this now, I will tag the 2.0.0 release. |
|
Have we done any breaking change that requires a major release? It doesn't seem so. |
|
My bad, I missed the deprecation of newFromArray. |
|
huh... I'm not really following, but keep in mind that deprecation is not a breaking change |
|
Deprecations are not breaking, but the dropped interface and the dropped constant are. ;-) |
No description provided.