Skip to content

Conversation

@JeroenDeDauw
Copy link
Member

No description provided.

README.md Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think the ~ character gives enough information. A common way to say "PHP 5.3 or later" is "PHP 5.3+". I have never seen the ~ outside of composer.json files and still find it confusing every time I see it. Please be bold.

@thiemowmde
Copy link
Contributor

thiemowmde commented Apr 27, 2015

Not necessarily objecting this pull request, but I wonder: the changes currently in this release are so minor and not important at all, I don't think this justifies a release. We can simply avoid using the removed stuff without a 2.0 release.

@JeroenDeDauw
Copy link
Member Author

Indeed, these changes are minor. I do not think we need this release. Neither do I think it hurts. I'm thinking that nothing much more significant is likely to happen though. Which would mean these minor changes where a waste of time for all intents and purposes.

README.md Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update this date before doing the actual release (a.k.a. tag).

@thiemowmde
Copy link
Contributor

I would merge this and do the release, but would like to know if we can agree on #25 possibly becoming part of this 2.0.0 release?

@JeroenDeDauw
Copy link
Member Author

Fine by me

@thiemowmde thiemowmde force-pushed the rel20 branch 2 times, most recently from a578c86 to 9f1cc88 Compare June 21, 2017 09:58
@thiemowmde
Copy link
Contributor

I rebased this again and updated the release notes to mention everything that changed since the last release. I also realized we never released 1.0.1. If somebody is willing to merge this now, I will tag the 2.0.0 release.

@Ladsgroup
Copy link
Contributor

Have we done any breaking change that requires a major release? It doesn't seem so.

@Ladsgroup
Copy link
Contributor

My bad, I missed the deprecation of newFromArray.

@Ladsgroup Ladsgroup merged commit 5d93044 into master Aug 2, 2017
@Ladsgroup Ladsgroup deleted the rel20 branch August 2, 2017 16:37
@JeroenDeDauw
Copy link
Member Author

huh... I'm not really following, but keep in mind that deprecation is not a breaking change

@thiemowmde
Copy link
Contributor

Deprecations are not breaking, but the dropped interface and the dropped constant are. ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants