Repository navigation
feat(lexicon): add Anthony Water & Sanitation District and Bramasole Farm organizations - #1057
Open
ksmuczynski wants to merge 1 commit into
Open
ksmuczynski wants to merge 1 commit into
ksmuczynski wants to merge 1 commit into
Conversation
Contact.organization is a foreign key to lexicon_term.term, so a contact's organization must already be a lexicon term. Anthony Water & Sanitation District and Bramasole Farm are not terms yet. No contact can be saved with either one as its organization. This commit inserts both terms in alphabetical order among the other organization terms. In this category a definition spells out an abbreviated term, for example Brazos MDWCA. Neither new name is abbreviated, so each definition is the same as its term. init_lexicon inserts only the terms a database is missing. Re-seeding an existing database adds these two and changes no other term. Deployed environments get them when someone runs `oco initialize-lexicon`.
Contributor
Coverage✅ 82.02% total — gate is 75%. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds Anthony Water & Sanitation District and Bramasole Farm to the lexicon as organization terms.
Why
This PR addresses the following problem / context:
How
Implementation summary - the following was changed / added / removed:
organizationterms incore/lexicon.json.Notes
Any special considerations, workarounds, or follow-up work to note?
jira-keycheck fails until someone adds theskip-bdms-checklabel.tests/test_lexicon.pyandtests/test_seed_prereqs.pyran against a local test database. Runninginit_lexiconon that database added both names underorganization.