Repository navigation
refactor(edr): manual water level contract data shape tests (BDMS-1542) - #1054
Open
jacob-a-brown wants to merge 3 commits into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This work will be done in a series of stacked PRs and therefore I expect these tests to fail until all of the subsequent PRs get approved and merged into this one.
Why
This PR addresses the following problem / context:
/manual_waterlevelscollection depend should be described by testsHow
Implementation summary: the following was changed / added / removed:
ogc_manual_waterlevelsviewAuthor Checklist
Reviewer Checklist
Notes
Any special considerations, known limitations, risks, workarounds, or follow-up work to note?
tests/test_ogc_field_descriptions.py::test_edr_independent_axis_documents_its_parametersalready exists in the branch into which this will be merged. I don't know why it's exists here. So it's in both this PR and the one above it.