Repository navigation
USGS Fix, NMBGMR Fix, & Other Updates #66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
83 commits
Select commit
Hold shift + click to select a range
c322402
fix(source): enable tag paramter for json requests to be Null
jacob-a-brown ec9f6e3
fix(config): update config/false agencies for bicarbonate
jacob-a-brown dcaf8d3
fix(USGS): use new USGS API endpoints for water level retrieval
jacob-a-brown 036e9e7
fix(usgs): update transformer for combined-metadata endpoint
jacob-a-brown 2425094
fix(usgs): update USGS water level retrieval for new APIs
jacob-a-brown 500a0b1
fix(usgs): set limit to 50000 to avoid pagination/rate limits
jacob-a-brown d93869d
refactor(usgs): check usgs health with get request
jacob-a-brown 12247f5
fix(config): set agencies for bicarbonate
jacob-a-brown 4eaac1c
fix(nmbgmr): set timeout to 30 minutes and retry failures
jacob-a-brown b342922
fix(usgs): add timeout to usgs api calls and retry logic if errors
jacob-a-brown 3f2d104
fix(usgs): add retry logic to pagination retrieval
jacob-a-brown 6005f70
refactor(usgs): set datum in site transformer
jacob-a-brown dba8213
fix(usgs): return False if health check fails
jacob-a-brown b17bbde
fix(usgs): shorten error message
jacob-a-brown 5570c36
fix(usgs): set limit of 1 for health check
jacob-a-brown 836243e
fix(usgs): remove unused imports
jacob-a-brown 4fd3ac6
fix(nmbgmr): retry when status_code!=200
jacob-a-brown 1fcede3
fix(nmbgmr): remove print debugging statement
jacob-a-brown c1771d7
fix(nmbgmr): call self.warn not warning
jacob-a-brown a51b13e
fix(usgs): call self.warn not warning
jacob-a-brown 43e2457
refactor(nmbgmr): change note style at top of doc
jacob-a-brown c17e806
refactor(retries): move rety logic to BaseSource
jacob-a-brown 4a64c6f
refactor(nmbgmr): change timeout to 15 minutes
jacob-a-brown 0e961a4
fix(nmbgmr): update developers note
jacob-a-brown 8dd54d7
fix(source): return null string outside of while loop
jacob-a-brown 32b6b25
fix(source): add URL to error message and log
jacob-a-brown 31271c6
fix(usgs): remove hardcoded API key
jacob-a-brown deed95f
fix(usgs): have users pass USGS API keys
jacob-a-brown 539fb13
fix(usgs): update README documentation
jacob-a-brown 6897f28
fix(documentation): make README more readable
jacob-a-brown 1d2bac9
fix(documentation): link to USGS API key acquisition
jacob-a-brown 5f886bb
fix(usgs): exit if rate limit exceeded
jacob-a-brown f9908fd
fix(usgs): disallow partial records if a rate limit error is hit
jacob-a-brown 7082957
fix(usgs): implement retries with exponential backoff
jacob-a-brown 148208b
refactor(exceptions): put custom exceptions in own script
jacob-a-brown f760bbb
fix(usgs): catch JSONDecodeError and retry
jacob-a-brown 1aff110
fix(usgs): check status_code for health check
jacob-a-brown 0af670e
fix(usgs): revert persister.records on partial completion
jacob-a-brown 690ba41
fix(partial records): don't persist partial records
jacob-a-brown 7424177
fix(usgs): make site source USGS-NWIS to correspond with field measur…
jacob-a-brown 013406d
feature(usgs): add dt params
jacob-a-brown 7d38c37
note(usgs): type hint variables
jacob-a-brown 8183300
test(usgs): use .env for api key for tests
jacob-a-brown 9bf3fc2
fix(usgs): Handle USGS rate limit and partial/no data errors
jacob-a-brown 43409f3
fix(test): don't override parent setup fixture
jacob-a-brown 441ff81
fix(test): remove env var outside of fixture
jacob-a-brown e524ec7
fix(requirements): download python-dotenv
jacob-a-brown 7af57d6
fix(test): load usgs api key from .env for every test
jacob-a-brown d7382bd
fix(unifier): remove partial persister.records on failure
jacob-a-brown 245b01f
fix(usgs): use truthiness check for usgs api key header
jacob-a-brown f5b2e2f
fix(style): two blank lines between classes
jacob-a-brown 85ab811
fix(usgs): fail health check on non 2xx status codes
jacob-a-brown 5cf9904
test(usgs api key): test usgs api key is env var when set via --usgs-…
jacob-a-brown 4f3b913
fix(test): reset usgs api key after each test
jacob-a-brown acd3360
Merge branch 'jab-nmbgmr-timeout-fix' into jab-usgs-fix
jacob-a-brown 8bd3ab4
fix(source): add retry logic to _execute_json_request and _execute_te…
jacob-a-brown 16201ba
fix(source): add retries and error handling for http requests
jacob-a-brown 46c15f1
fix(usgs): check for HTTPError instead of HTTPStatusError to for heal…
jacob-a-brown 3db9946
fix(unifier): Warn when unable to retrieve complete records after mul…
jacob-a-brown 7f3cfa7
feat(unifier): Add more specific warning messages for incomplete records
jacob-a-brown 60adf96
feat(usgs): add pagination check for water-level queries
jacob-a-brown 22b0c33
fix(test): fix USGS API key handling in CLI tests
jacob-a-brown 869e058
fix(logger): Handle potential file descriptor leaks by removing exist…
jacob-a-brown 3a3f345
feat(error): log URL on error
jacob-a-brown ade753a
fix(tests): reset env var in USGS tests
jacob-a-brown e75be0a
fix(health): return False if exception is raised in health check
jacob-a-brown 49abe13
fix(usgs): correct site collection error message
jacob-a-brown bab5252
fix(logger): Ensure only managed handlers are closed
jacob-a-brown eafa40f
fix(usgs): Add parameter code filter to USGS data retrieval if not si…
jacob-a-brown 0c29a8a
feat(version): Update version to 0.10.1
jacob-a-brown 3d6d41a
fix(usgs): update usgs parameter reader to enable None and number values
jacob-a-brown 5a7c01f
fix(nmbgmr): Check for features in response to determine if API is wo…
jacob-a-brown 982b72a
fix(usgs): make sure sites is always list
jacob-a-brown b9ac492
fix(health): update health checks to return false if get_records retu…
jacob-a-brown 9560e0b
fix(st2 health): Update health checks to probe service directly
jacob-a-brown e40aa64
fix(usgs health check): decrease timeout for health check to avoid lo…
jacob-a-brown 1d45571
fix(usgs): remove dead code for pagination
jacob-a-brown 8b20e34
update(README): added note about USGS API key for die sites
jacob-a-brown 0c685e1
fix(doc): update source _execute_json_request return type to always b…
jacob-a-brown 074c17f
fix(documentation): remove repeated word in comment
jacob-a-brown 45916b2
fix(README): use "for their APIs" instead of "to their APIs"
jacob-a-brown de660d8
fix(nmenv): list method hangs up service in health check
jacob-a-brown 1e3d418
fix(readme): indicate api key for site and water level data from usgs
jacob-a-brown File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.