Repository navigation
feat(trends): add fixed window water level trend layers 5 10 20 years (DIE-400) - #154
Open
chasetmartin wants to merge 3 commits into
Open
chasetmartin wants to merge 3 commits into
chasetmartin wants to merge 3 commits into
Conversation
Every trend is now tested on one value per calendar month: the median for depth-to-water, the mean for analytes. A single analyte flag picks both the aggregate and the method text, so they always agree. Trend collections can be limited to a trailing window of whole calendar months before the run month, using one run date per Dagster run. Features carry trend_period, window_years, window_start/window_end and an insufficient_reason when the minimum-data rule fails.
Add nm_waterlevel_trends_5yr/_10yr/_20yr. nm_waterlevel_trends is relabeled as the full-record (overall) trend; its id is unchanged. Analyte trend abstracts now describe the monthly mean.
|
Your pull request is automatically being deployed to Dagster Cloud.
|
chasetmartin
changed the title
jacob-a-brown
left a comment
jacob-a-brown
left a comment
Contributor
There was a problem hiding this comment.
Overall I think it looks! I made one comment about slope in feet per year. If you agree with my comment then the same update needs to be applied elsewhere. I just didn't want to litter this PR with the same comment throughout.
Comment on lines
+101
to
+102
| with the Mann-Kendall test (alpha = 0.05), with the rate given as a Theil-Sen | ||
| slope in feet per year. Wells need at least 10 monthly values, or at least 4 |
Contributor
There was a problem hiding this comment.
if this is tested on monthly data wouldn't it be slope per month?
Contributor
Author
There was a problem hiding this comment.
The series is now aggregated to monthly, but I believe the Theil-Sen slope is fit against year timestamps slope_per_year = float(theilslopes(values, years)[0]), so the slopes are ft/yr.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
This PR addresses the following problem / context:
How
Implementation summary: the following was changed / added / removed:
nm_waterlevel_trends_5yr,_10yrand_20yr. Each window covers whole calendar months before the run month and is the same for every well.nm_waterlevel_trendsis retitled "Full Record" to mark it as the overall trend. Its id is unchanged.trend_period,window_years,window_start,window_end,insufficient_reason.Author Checklist
Reviewer Checklist
nm_waterlevel_trendsid while retitling it is acceptable.Notes
Any special considerations, known limitations, risks, workarounds, or follow-up work to note?