Skip to content

feat(pygeoapi): add source analyte lists to landing page (DIE-368) - #151

Merged
jacob-a-brown merged 1 commit into
mainfrom
DIE-368-add-source-analyte-lists-to-pygeoapi-landing-page-if-possible-in-a-reasonable-way
Oct 27, 2026
Merged

jacob-a-brown merged 1 commit into
mainfrom
DIE-368-add-source-analyte-lists-to-pygeoapi-landing-page-if-possible-in-a-reasonable-way

Conversation

@jacob-a-brown

Copy link
Copy Markdown
Contributor

Why

This PR addresses the following problem / context:

  • the landing page should display a table indicating which source reports which parameters

How

Implementation summary - the following was changed / added / removed:

  • Updated the landing page to include source analyte lists for each data source. This required explicitly defining the landing page with custom HTML templates, as the default landing page provided by pygeoapi did not support this level of customization.

Notes

Any special considerations, workarounds, or follow-up work to note?

  • 🚨 This table is hard-coded. It would be great if we could maintain a list someone to create this table so that it can be easily reflected in updates. Perhaps a technical debt ticket? Or, would you like for me to do that now? To future-proof this work

Updated the landing page to include source analyte lists for each data source.
This required explicitly defining the landing page with custom HTML templates,
as the default landing page provided by pygeoapi did not support this level of customization.
See orchestration/pygeoapi/templates/landing_page.html for the custom HTML template used and
https://docs.pygeoapi.io/en/latest/html-templating.html for more information on pygeoapi HTML templating.
@github-actions

github-actions Bot commented Oct 26, 2026 •

Copy link
Copy Markdown

Your pull request is automatically being deployed to Dagster Cloud.

Location Status Link Updated
die-orchestration View in Cloud Oct 26, 2026 at 11:49 PM (UTC)

@chasetmartin chasetmartin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. I think we note your suggestion about more easily compiling or producing the table via the config and add it to the backlog

@jacob-a-brown
jacob-a-brown merged commit 21c9b28 into main Oct 27, 2026
3 of 4 checks passed
@jacob-a-brown
jacob-a-brown deleted the DIE-368-add-source-analyte-lists-to-pygeoapi-landing-page-if-possible-in-a-reasonable-way branch October 27, 2026 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants