Repository navigation
DIE-374: Add a summary product for every fetched analyte - #150
Merged
chasetmartin merged 1 commit intoOct 26, 2026
Merged
Conversation
Adds nm_<analyte>_summary for the 9 fetched analytes that had a time series but no summary (nitrate, sulfate, chloride, calcium, magnesium, sodium, potassium, bicarbonate, carbonate). They reuse the analyte cohort's shared source assets, so the source asset count is unchanged (68).
|
Your pull request is automatically being deployed to Dagster Cloud.
|
jacob-a-brown
approved these changes
Oct 26, 2026
chasetmartin
deleted the
DIE-374-add-a-summary-product-for-every-analyte
branch
October 29, 2026 17:07
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an
nm_<analyte>_summaryproduct (ogc_summary) for each of the 9 fetched analytes that had a time series but no summary: nitrate, sulfate, chloride, calcium, magnesium, sodium, potassium, bicarbonate, carbonate. With the existing arsenic, TDS, fluoride and uranium summaries, every analyte with a time-series product now has a summary product too.The new products run on the analyte cohort schedule (
0 6 25 * *) and reuse the cohort's shared source assets, so there are no new source fetches. The summary combine and pygeoapi already handleogc_summary, so this is config only. Noted in SPEC §5.2.Not included, same as DIE-373: silica, conductivity, specific_conductance and ph (none is fetched by another product, so each would add source fetches), and DIE-306 metadata (abstract, keywords, data-dictionary section).
Testing:
dg check defspasses. 68 source assets before and after, and all 9 new products are in theanalytes_state_NMcohort.pytest tests: 283 passed, 2 skipped. Not yet run in a branch deployment or served from pygeoapi, so units (mg/L, incl. the nitrate-as-N and CaCO3 conversions) are still to be checked on the first run.