Add new setting to allow renaming service by tag - #975
Merged
Conversation
This is a more generic form of the previous `split-by-domain` and `split-by-instance`. (Note: evaluation is done when a tag is set, so If multiple tags are configured, the last tag set will take precidence.) For example, this setting can be used to rename `aws-sdk` spans to be identified with the corresponding `aws.service` tag: ``` -Ddd.trace.split-by-tags=aws.service ``` There are some slight differences with this setting compared with`dd.trace.http.client.split-by-domain` and `dd.trace.db.client.split-by-instance`. `split-by-tags` applies to every span, where `split-by-domain` and `split-by-instance` only apply to http and db client spans respectively.
tylerbenson
force-pushed
the
tyler/split-by-tag
branch
from
September 3, 2019 23:56
52e00ca to
82f5076
Compare
randomanderson
approved these changes
Sep 5, 2019
randomanderson
left a comment
randomanderson
left a comment
Contributor
There was a problem hiding this comment.
Going through, this is a small change that affected a bunch of files. 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a more generic form of the previous
split-by-domainandsplit-by-instance.(Note: evaluation is done when a tag is set, so If multiple tags are configured, the last tag set will take precidence.)
For example, this setting can be used to rename
aws-sdkspans to be identified with the correspondingaws.servicetag:There are some slight differences with this setting compared with
dd.trace.http.client.split-by-domainanddd.trace.db.client.split-by-instance.split-by-tagsapplies to every span, wheresplit-by-domainandsplit-by-instanceonly apply to http and db client spans respectively.