Update Mongo instance name and remove memcache instance name#880
Merged
tylerbenson merged 6 commits intomasterfrom Jun 13, 2019
Merged
Update Mongo instance name and remove memcache instance name#880tylerbenson merged 6 commits intomasterfrom
tylerbenson merged 6 commits intomasterfrom
Conversation
Otherwise there is a race condition between the projects initializing the mongo instance.
For mongo, use description if set, fallback to db name. Memcache doesn’t have a good “instance name” that would work as service name, so clear it out for now.
tylerbenson
force-pushed
the
tyler/mongo-instance
branch
from
a14ae1d to
3be6868
Compare
mar-kolya
approved these changes
Jun 13, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For mongo, use description if set, fallback to db name.
Memcache doesn’t have a good “instance name” that would work as service name, so clear it out for now.