Add http.query.string tag when enabled#860
Merged
tylerbenson merged 6 commits intomasterfrom May 31, 2019
Merged
Conversation
Add flexibility to handle inconsistencies between client integrations.
Disabled by default. Enable for http servers with: * System Property: `dd.http.server.tag.query-string=true` * Environment Variable: `DD_HTTP_SERVER_TAG_QUERY_STRING=true` Enable for http clients with: * System Property: `dd.http.client.tag.query-string=true` * Environment Variable: `DD_HTTP_CLIENT_TAG_QUERY_STRING=true`
tylerbenson
force-pushed
the
tyler/http.query.string
branch
from
ac0a3cb to
fc9f1d1
Compare
Notably added a transformer to make config easier to test with by making INSTANCE public static volatile.
tylerbenson
force-pushed
the
tyler/http.query.string
branch
from
dc1d589 to
ff9ee0d
Compare
tylerbenson
force-pushed
the
tyler/http.query.string
branch
from
ff9ee0d to
9cdf049
Compare
labbati
requested changes
May 31, 2019
Member
labbati
left a comment
labbati
left a comment
There was a problem hiding this comment.
Awesome PR, I was able to clearly understand the intent I was navigating through the code.
I added a few questions but most of them are optional.
I tried to check all test changes and I am pretty sure you nailed them! But this is the famous cross-your-fingers type of test refactoring 😄
...ava-agent/agent-tooling/src/main/java/datadog/trace/agent/decorator/HttpServerDecorator.java
Outdated
Show resolved
Hide resolved
...gent/instrumentation/akka-http-10.0/src/test/groovy/AkkaHttpClientInstrumentationTest.groovy
Outdated
Show resolved
Hide resolved
...t/agent-tooling/src/test/groovy/datadog/trace/agent/decorator/HttpServerDecoratorTest.groovy
Outdated
Show resolved
Hide resolved
dd-java-agent/testing/src/main/groovy/datadog/trace/agent/test/utils/ConfigUtils.groovy
Show resolved
Hide resolved
dd-java-agent/testing/src/main/groovy/datadog/trace/agent/test/utils/ConfigUtils.groovy
Show resolved
Hide resolved
dd-java-agent/testing/src/main/groovy/datadog/trace/agent/test/utils/TraceUtils.groovy
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Disabled by default.
Enable for http servers with:
dd.http.server.tag.query-string=trueDD_HTTP_SERVER_TAG_QUERY_STRING=trueEnable for http clients with:
dd.http.client.tag.query-string=trueDD_HTTP_CLIENT_TAG_QUERY_STRING=trueAlso contains a big commit that refactors all the http client unit tests to extend from the base
HttpTestClient. Eventually it would be nice to reduce the need for all the inconsistencies.