Provide instrumentation name context to span - #5492
Merged
Merged
Conversation
PerfectSlayer
added
comp: telemetry
BenchmarksParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 22 cases. |
Contributor
|
Nice - this would be a good context field to add to profile samples. We would need to dictionarize the instrumentation name and set it through the profiling context integration the way we do the span name currently. I will watch the PR to know when it's available to build against. |
PerfectSlayer
force-pushed
the
bbujon/telemetry-improvements
branch
from
June 29, 2023 14:56
e6e5b03 to
1ae77d5
Compare
bantonsson
reviewed
Jun 30, 2023
bantonsson
approved these changes
Jun 30, 2023
PerfectSlayer
force-pushed
the
bbujon/telemetry-improvements
branch
from
June 30, 2023 16:31
1a86923 to
e077dd5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Does This Do
This PR introduce instrumentation name as context to the span.
The context was added for the following cases:
Motivation
This is required for span metrics.
Additional Notes
This PR is the third part of the Span Metrics PR #5382
I might do a pass in most of instrumentations to add this context if needed in another PR.
There might be complication with common decorator though.