WIP: Span metrics - #5382
Closed
PerfectSlayer wants to merge 16 commits into
Closed
Conversation
PerfectSlayer
added
tag: do not merge
BenchmarksParameters
See matching parameters
SummaryFound 0 performance improvements and 1 performance regressions! Performance is the same for 21 cases.
|
PerfectSlayer
force-pushed
the
bbujon/telemetry-metrics
branch
7 times, most recently
from
June 16, 2023 12:01
c97f273 to
bd49ba2
Compare
PerfectSlayer
force-pushed
the
bbujon/telemetry-metrics
branch
from
June 26, 2023 13:19
05e8ce3 to
78786b8
Compare
This was referenced Jun 27, 2023
Merged
Collaborator
Author
|
The whole feature was merged to the linked PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Does This Do
Motivation
A generic metrics API allow gathering metrics from core and dispatch them later to either health metrics or telemetry (or both).
It should also allow deviated metrics in a longer term. Current metric implementations are either for client or telemetric but isn't generic.
Additional Notes
This PR is still in WIP. I will split it in two distinct PRs later: one for the metric API, another for span metrics.
For now, the new metric API is only directly linked to telemetry using the recently supported periodic action for telemetry metric payload.