Skip to content

Conversation

@bantonsson
Copy link
Contributor

@bantonsson bantonsson commented Jan 21, 2022

What Does This Do

  • Changes all compile/runtime configurations to implementation/runtimeOnly
  • Switches to the new supported play framework plugin

Motivation

These constructs are no longer supported on gradle 7.x and would fail the build

Additional Notes

The biggest blocker now is the muzzle instrumentation plugin that is beyond my current understanding of gradle, as well as the :dd-java-agent:appsec:weblog:weblog-spring-app that uses old versions of Spring and the Spring Boot plugin.

@bantonsson bantonsson added tag: no release notes Changes to exclude from release notes comp: tooling Build & Tooling labels Jan 21, 2022
@bantonsson bantonsson self-assigned this Jan 21, 2022
@bantonsson bantonsson requested review from a team and ValentinZakharov as code owners January 21, 2022 14:41
@bantonsson bantonsson marked this pull request as draft January 21, 2022 14:49
@charliegracie
Copy link
Contributor

charliegracie commented Jan 21, 2022

Sorry for the churn... accidentally approved :(... Removed my approval

@charliegracie charliegracie self-requested a review January 21, 2022 15:32
@bantonsson bantonsson force-pushed the ban/gradle-cleanup branch 3 times, most recently from 44f1192 to 5ff1da2 Compare January 25, 2022 10:21
@bantonsson bantonsson marked this pull request as ready for review January 25, 2022 12:55
Copy link
Contributor

@mcculls mcculls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@bantonsson bantonsson merged commit 33da82e into master Jan 25, 2022
@bantonsson bantonsson deleted the ban/gradle-cleanup branch January 25, 2022 14:56
@github-actions github-actions bot added this to the 0.94.0 milestone Jan 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp: tooling Build & Tooling tag: no release notes Changes to exclude from release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants