-
Notifications
You must be signed in to change notification settings - Fork 324
Make minor readability improvements to README and BUILDING files #10531
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make minor readability improvements to README and BUILDING files #10531
Conversation
|
Hi! 👋 Thanks for your pull request! 🎉 To help us review it, please make sure to:
If you need help, please check our contributing guidelines. |
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 61 metrics, 10 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.60.0-SNAPSHOT~8f1600013b, baseline=1.60.0-SNAPSHOT~8c26540173
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.066 s) : 0, 1065531
Total [baseline] (8.733 s) : 0, 8733393
Agent [candidate] (1.068 s) : 0, 1068267
Total [candidate] (8.725 s) : 0, 8725022
section iast
Agent [baseline] (1.235 s) : 0, 1235129
Total [baseline] (9.421 s) : 0, 9421444
Agent [candidate] (1.241 s) : 0, 1241458
Total [candidate] (9.447 s) : 0, 9446528
gantt
title insecure-bank - break down per module: candidate=1.60.0-SNAPSHOT~8f1600013b, baseline=1.60.0-SNAPSHOT~8c26540173
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.188 ms) : 0, 1188
crashtracking [candidate] (1.178 ms) : 0, 1178
BytebuddyAgent [baseline] (629.075 ms) : 0, 629075
BytebuddyAgent [candidate] (629.731 ms) : 0, 629731
AgentMeter [baseline] (29.013 ms) : 0, 29013
AgentMeter [candidate] (29.004 ms) : 0, 29004
GlobalTracer [baseline] (257.855 ms) : 0, 257855
GlobalTracer [candidate] (259.45 ms) : 0, 259450
AppSec [baseline] (32.658 ms) : 0, 32658
AppSec [candidate] (33.024 ms) : 0, 33024
Debugger [baseline] (62.887 ms) : 0, 62887
Debugger [candidate] (60.849 ms) : 0, 60849
Remote Config [baseline] (605.396 µs) : 0, 605
Remote Config [candidate] (618.392 µs) : 0, 618
Telemetry [baseline] (11.417 ms) : 0, 11417
Telemetry [candidate] (13.786 ms) : 0, 13786
Flare Poller [baseline] (5.36 ms) : 0, 5360
Flare Poller [candidate] (5.295 ms) : 0, 5295
section iast
crashtracking [baseline] (1.22 ms) : 0, 1220
crashtracking [candidate] (1.195 ms) : 0, 1195
BytebuddyAgent [baseline] (800.192 ms) : 0, 800192
BytebuddyAgent [candidate] (802.983 ms) : 0, 802983
AgentMeter [baseline] (11.285 ms) : 0, 11285
AgentMeter [candidate] (11.567 ms) : 0, 11567
GlobalTracer [baseline] (247.699 ms) : 0, 247699
GlobalTracer [candidate] (249.115 ms) : 0, 249115
IAST [baseline] (26.846 ms) : 0, 26846
IAST [candidate] (27.33 ms) : 0, 27330
AppSec [baseline] (34.06 ms) : 0, 34060
AppSec [candidate] (31.71 ms) : 0, 31710
Debugger [baseline] (65.697 ms) : 0, 65697
Debugger [candidate] (69.287 ms) : 0, 69287
Remote Config [baseline] (544.137 µs) : 0, 544
Remote Config [candidate] (542.091 µs) : 0, 542
Telemetry [baseline] (8.659 ms) : 0, 8659
Telemetry [candidate] (8.821 ms) : 0, 8821
Flare Poller [baseline] (3.53 ms) : 0, 3530
Flare Poller [candidate] (3.541 ms) : 0, 3541
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.60.0-SNAPSHOT~8f1600013b, baseline=1.60.0-SNAPSHOT~8c26540173
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.068 s) : 0, 1068191
Total [baseline] (10.75 s) : 0, 10749552
Agent [candidate] (1.064 s) : 0, 1064189
Total [candidate] (10.873 s) : 0, 10872674
section appsec
Agent [baseline] (1.241 s) : 0, 1240890
Total [baseline] (10.99 s) : 0, 10990065
Agent [candidate] (1.237 s) : 0, 1237207
Total [candidate] (11.039 s) : 0, 11038829
section iast
Agent [baseline] (1.23 s) : 0, 1230257
Total [baseline] (11.175 s) : 0, 11175043
Agent [candidate] (1.234 s) : 0, 1233844
Total [candidate] (11.152 s) : 0, 11152489
section profiling
Agent [baseline] (1.197 s) : 0, 1197189
Total [baseline] (11.007 s) : 0, 11006906
Agent [candidate] (1.196 s) : 0, 1195718
Total [candidate] (11.066 s) : 0, 11065958
gantt
title petclinic - break down per module: candidate=1.60.0-SNAPSHOT~8f1600013b, baseline=1.60.0-SNAPSHOT~8c26540173
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.182 ms) : 0, 1182
crashtracking [candidate] (1.175 ms) : 0, 1175
BytebuddyAgent [baseline] (630.069 ms) : 0, 630069
BytebuddyAgent [candidate] (628.823 ms) : 0, 628823
AgentMeter [baseline] (28.863 ms) : 0, 28863
AgentMeter [candidate] (28.83 ms) : 0, 28830
GlobalTracer [baseline] (258.25 ms) : 0, 258250
GlobalTracer [candidate] (258.027 ms) : 0, 258027
AppSec [baseline] (32.899 ms) : 0, 32899
AppSec [candidate] (32.693 ms) : 0, 32693
Debugger [baseline] (62.77 ms) : 0, 62770
Debugger [candidate] (60.906 ms) : 0, 60906
Remote Config [baseline] (612.199 µs) : 0, 612
Remote Config [candidate] (617.645 µs) : 0, 618
Telemetry [baseline] (12.905 ms) : 0, 12905
Telemetry [candidate] (12.369 ms) : 0, 12369
Flare Poller [baseline] (5.349 ms) : 0, 5349
Flare Poller [candidate] (5.313 ms) : 0, 5313
section appsec
crashtracking [baseline] (1.192 ms) : 0, 1192
crashtracking [candidate] (1.183 ms) : 0, 1183
BytebuddyAgent [baseline] (659.542 ms) : 0, 659542
BytebuddyAgent [candidate] (657.068 ms) : 0, 657068
AgentMeter [baseline] (11.856 ms) : 0, 11856
AgentMeter [candidate] (11.868 ms) : 0, 11868
GlobalTracer [baseline] (259.26 ms) : 0, 259260
GlobalTracer [candidate] (258.313 ms) : 0, 258313
AppSec [baseline] (168.32 ms) : 0, 168320
AppSec [candidate] (167.61 ms) : 0, 167610
Debugger [baseline] (66.821 ms) : 0, 66821
Debugger [candidate] (67.349 ms) : 0, 67349
Remote Config [baseline] (665.896 µs) : 0, 666
Remote Config [candidate] (668.919 µs) : 0, 669
Telemetry [baseline] (8.988 ms) : 0, 8988
Telemetry [candidate] (9.139 ms) : 0, 9139
Flare Poller [baseline] (3.57 ms) : 0, 3570
Flare Poller [candidate] (3.668 ms) : 0, 3668
IAST [baseline] (25.327 ms) : 0, 25327
IAST [candidate] (25.105 ms) : 0, 25105
section iast
crashtracking [baseline] (1.184 ms) : 0, 1184
crashtracking [candidate] (1.179 ms) : 0, 1179
BytebuddyAgent [baseline] (795.235 ms) : 0, 795235
BytebuddyAgent [candidate] (797.313 ms) : 0, 797313
AgentMeter [baseline] (11.223 ms) : 0, 11223
AgentMeter [candidate] (11.254 ms) : 0, 11254
GlobalTracer [baseline] (247.433 ms) : 0, 247433
GlobalTracer [candidate] (248.1 ms) : 0, 248100
AppSec [baseline] (33.068 ms) : 0, 33068
AppSec [candidate] (32.27 ms) : 0, 32270
Debugger [baseline] (67.188 ms) : 0, 67188
Debugger [candidate] (68.58 ms) : 0, 68580
Remote Config [baseline] (556.815 µs) : 0, 557
Remote Config [candidate] (541.224 µs) : 0, 541
Telemetry [baseline] (8.737 ms) : 0, 8737
Telemetry [candidate] (8.72 ms) : 0, 8720
Flare Poller [baseline] (3.545 ms) : 0, 3545
Flare Poller [candidate] (3.526 ms) : 0, 3526
IAST [baseline] (26.883 ms) : 0, 26883
IAST [candidate] (27.049 ms) : 0, 27049
section profiling
ProfilingAgent [baseline] (99.115 ms) : 0, 99115
ProfilingAgent [candidate] (99.264 ms) : 0, 99264
crashtracking [baseline] (1.241 ms) : 0, 1241
crashtracking [candidate] (1.225 ms) : 0, 1225
BytebuddyAgent [baseline] (687.3 ms) : 0, 687300
BytebuddyAgent [candidate] (686.378 ms) : 0, 686378
AgentMeter [baseline] (8.814 ms) : 0, 8814
AgentMeter [candidate] (8.746 ms) : 0, 8746
GlobalTracer [baseline] (217.25 ms) : 0, 217250
GlobalTracer [candidate] (216.191 ms) : 0, 216191
AppSec [baseline] (32.368 ms) : 0, 32368
AppSec [candidate] (32.474 ms) : 0, 32474
Debugger [baseline] (67.823 ms) : 0, 67823
Debugger [candidate] (67.989 ms) : 0, 67989
Remote Config [baseline] (586.759 µs) : 0, 587
Remote Config [candidate] (601.438 µs) : 0, 601
Telemetry [baseline] (8.784 ms) : 0, 8784
Telemetry [candidate] (8.883 ms) : 0, 8883
Flare Poller [baseline] (3.774 ms) : 0, 3774
Flare Poller [candidate] (3.755 ms) : 0, 3755
Profiling [baseline] (99.689 ms) : 0, 99689
Profiling [candidate] (99.842 ms) : 0, 99842
LoadParameters
See matching parameters
SummaryFound 2 performance improvements and 0 performance regressions! Performance is the same for 16 metrics, 18 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.60.0-SNAPSHOT~8f1600013b, baseline=1.60.0-SNAPSHOT~8c26540173
dateFormat X
axisFormat %s
section baseline
no_agent (19.175 ms) : 18980, 19370
. : milestone, 19175,
appsec (18.855 ms) : 18665, 19045
. : milestone, 18855,
code_origins (18.414 ms) : 18225, 18602
. : milestone, 18414,
iast (17.538 ms) : 17363, 17712
. : milestone, 17538,
profiling (18.922 ms) : 18730, 19114
. : milestone, 18922,
tracing (17.697 ms) : 17523, 17872
. : milestone, 17697,
section candidate
no_agent (18.317 ms) : 18128, 18505
. : milestone, 18317,
appsec (18.829 ms) : 18637, 19022
. : milestone, 18829,
code_origins (17.567 ms) : 17390, 17743
. : milestone, 17567,
iast (17.603 ms) : 17432, 17775
. : milestone, 17603,
profiling (18.774 ms) : 18584, 18964
. : milestone, 18774,
tracing (17.527 ms) : 17354, 17701
. : milestone, 17527,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.60.0-SNAPSHOT~8f1600013b, baseline=1.60.0-SNAPSHOT~8c26540173
dateFormat X
axisFormat %s
section baseline
no_agent (1.17 ms) : 1159, 1181
. : milestone, 1170,
iast (3.064 ms) : 3025, 3102
. : milestone, 3064,
iast_FULL (5.801 ms) : 5743, 5859
. : milestone, 5801,
iast_GLOBAL (3.446 ms) : 3394, 3498
. : milestone, 3446,
profiling (2.317 ms) : 2294, 2341
. : milestone, 2317,
tracing (1.815 ms) : 1800, 1830
. : milestone, 1815,
section candidate
no_agent (1.2 ms) : 1189, 1212
. : milestone, 1200,
iast (3.223 ms) : 3179, 3266
. : milestone, 3223,
iast_FULL (5.727 ms) : 5670, 5784
. : milestone, 5727,
iast_GLOBAL (3.302 ms) : 3255, 3350
. : milestone, 3302,
profiling (2.147 ms) : 2128, 2165
. : milestone, 2147,
tracing (1.816 ms) : 1801, 1831
. : milestone, 1816,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.60.0-SNAPSHOT~8f1600013b, baseline=1.60.0-SNAPSHOT~8c26540173
dateFormat X
axisFormat %s
section baseline
no_agent (14.957 s) : 14957000, 14957000
. : milestone, 14957000,
appsec (14.816 s) : 14816000, 14816000
. : milestone, 14816000,
iast (18.018 s) : 18018000, 18018000
. : milestone, 18018000,
iast_GLOBAL (17.999 s) : 17999000, 17999000
. : milestone, 17999000,
profiling (14.944 s) : 14944000, 14944000
. : milestone, 14944000,
tracing (15.158 s) : 15158000, 15158000
. : milestone, 15158000,
section candidate
no_agent (15.612 s) : 15612000, 15612000
. : milestone, 15612000,
appsec (15.237 s) : 15237000, 15237000
. : milestone, 15237000,
iast (18.492 s) : 18492000, 18492000
. : milestone, 18492000,
iast_GLOBAL (18.08 s) : 18080000, 18080000
. : milestone, 18080000,
profiling (15.018 s) : 15018000, 15018000
. : milestone, 15018000,
tracing (15.041 s) : 15041000, 15041000
. : milestone, 15041000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.60.0-SNAPSHOT~8f1600013b, baseline=1.60.0-SNAPSHOT~8c26540173
dateFormat X
axisFormat %s
section baseline
no_agent (1.475 ms) : 1463, 1487
. : milestone, 1475,
appsec (3.794 ms) : 3574, 4014
. : milestone, 3794,
iast (2.255 ms) : 2186, 2324
. : milestone, 2255,
iast_GLOBAL (2.311 ms) : 2241, 2381
. : milestone, 2311,
profiling (2.119 ms) : 2062, 2175
. : milestone, 2119,
tracing (2.071 ms) : 2017, 2125
. : milestone, 2071,
section candidate
no_agent (1.476 ms) : 1464, 1487
. : milestone, 1476,
appsec (3.773 ms) : 3552, 3994
. : milestone, 3773,
iast (2.262 ms) : 2193, 2331
. : milestone, 2262,
iast_GLOBAL (2.297 ms) : 2228, 2366
. : milestone, 2297,
profiling (2.08 ms) : 2026, 2135
. : milestone, 2080,
tracing (2.059 ms) : 2006, 2112
. : milestone, 2059,
|
|
View all feedbacks in Devflow UI.
Arguments errors:
If you need support, contact us on Slack #devflow with those details! |
|
View all feedbacks in Devflow UI.
Arguments errors:
If you need support, contact us on Slack #devflow with those details! |
|
View all feedbacks in Devflow UI.
You need to provide a reason for skipping checks |
|
/merge -f --reason "Test reason" |
|
View all feedbacks in Devflow UI.
The expected merge time in
Warning This change was merged without running any pre merge CI checks Reason: Test reason |
What Does This Do
Make minor readability improvements to the
README.mdandBUILDING.mdfilesMotivation
Improve our documentation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]