Add rate limit on span decoration probe errors#10529
Add rate limit on span decoration probe errors#10529gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit intomasterfrom
Conversation
if an evaluation error is generated by a span decoration probe we are rate limiting it
|
Hi! 👋 Thanks for your pull request! 🎉 To help us review it, please make sure to:
If you need help, please check our contributing guidelines. |
Debugger benchmarksParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 9 metrics, 6 unstable metrics. See unchanged results
Request duration reports for reportsgantt
title reports - request duration [CI 0.99] : candidate=None, baseline=None
dateFormat X
axisFormat %s
section baseline
noprobe (319.232 µs) : 278, 360
. : milestone, 319,
basic (276.875 µs) : 270, 284
. : milestone, 277,
loop (8.957 ms) : 8952, 8962
. : milestone, 8957,
section candidate
noprobe (310.81 µs) : 288, 334
. : milestone, 311,
basic (273.624 µs) : 267, 280
. : milestone, 274,
loop (8.962 ms) : 8957, 8968
. : milestone, 8962,
|
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 66 metrics, 5 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.60.0-SNAPSHOT~84ab56b1f9, baseline=1.60.0-SNAPSHOT~9c3d035f5f
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.06 s) : 0, 1060201
Total [baseline] (8.717 s) : 0, 8717261
Agent [candidate] (1.062 s) : 0, 1062428
Total [candidate] (8.71 s) : 0, 8709515
section iast
Agent [baseline] (1.23 s) : 0, 1230162
Total [baseline] (9.348 s) : 0, 9348204
Agent [candidate] (1.229 s) : 0, 1228816
Total [candidate] (9.341 s) : 0, 9341254
gantt
title insecure-bank - break down per module: candidate=1.60.0-SNAPSHOT~84ab56b1f9, baseline=1.60.0-SNAPSHOT~9c3d035f5f
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.186 ms) : 0, 1186
crashtracking [candidate] (1.189 ms) : 0, 1189
BytebuddyAgent [baseline] (626.685 ms) : 0, 626685
BytebuddyAgent [candidate] (627.14 ms) : 0, 627140
AgentMeter [baseline] (28.832 ms) : 0, 28832
AgentMeter [candidate] (28.753 ms) : 0, 28753
GlobalTracer [baseline] (257.124 ms) : 0, 257124
GlobalTracer [candidate] (257.298 ms) : 0, 257298
AppSec [baseline] (32.863 ms) : 0, 32863
AppSec [candidate] (32.726 ms) : 0, 32726
Debugger [baseline] (63.144 ms) : 0, 63144
Debugger [candidate] (60.936 ms) : 0, 60936
Remote Config [baseline] (610.402 µs) : 0, 610
Remote Config [candidate] (623.402 µs) : 0, 623
Telemetry [baseline] (10.666 ms) : 0, 10666
Telemetry [candidate] (11.481 ms) : 0, 11481
Flare Poller [baseline] (3.793 ms) : 0, 3793
Flare Poller [candidate] (6.943 ms) : 0, 6943
section iast
crashtracking [baseline] (1.178 ms) : 0, 1178
crashtracking [candidate] (1.193 ms) : 0, 1193
BytebuddyAgent [baseline] (794.903 ms) : 0, 794903
BytebuddyAgent [candidate] (795.126 ms) : 0, 795126
AgentMeter [baseline] (11.28 ms) : 0, 11280
AgentMeter [candidate] (11.257 ms) : 0, 11257
GlobalTracer [baseline] (247.834 ms) : 0, 247834
GlobalTracer [candidate] (247.185 ms) : 0, 247185
IAST [baseline] (27.061 ms) : 0, 27061
IAST [candidate] (26.849 ms) : 0, 26849
AppSec [baseline] (33.166 ms) : 0, 33166
AppSec [candidate] (35.517 ms) : 0, 35517
Debugger [baseline] (66.809 ms) : 0, 66809
Debugger [candidate] (63.757 ms) : 0, 63757
Remote Config [baseline] (543.925 µs) : 0, 544
Remote Config [candidate] (534.09 µs) : 0, 534
Telemetry [baseline] (8.639 ms) : 0, 8639
Telemetry [candidate] (8.696 ms) : 0, 8696
Flare Poller [baseline] (3.498 ms) : 0, 3498
Flare Poller [candidate] (3.481 ms) : 0, 3481
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.60.0-SNAPSHOT~84ab56b1f9, baseline=1.60.0-SNAPSHOT~9c3d035f5f
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.066 s) : 0, 1066234
Total [baseline] (10.917 s) : 0, 10916564
Agent [candidate] (1.066 s) : 0, 1066366
Total [candidate] (10.913 s) : 0, 10913236
section appsec
Agent [baseline] (1.233 s) : 0, 1232677
Total [baseline] (10.907 s) : 0, 10907066
Agent [candidate] (1.239 s) : 0, 1238805
Total [candidate] (10.924 s) : 0, 10923997
section iast
Agent [baseline] (1.232 s) : 0, 1231786
Total [baseline] (11.153 s) : 0, 11152643
Agent [candidate] (1.24 s) : 0, 1239886
Total [candidate] (11.162 s) : 0, 11162047
section profiling
Agent [baseline] (1.194 s) : 0, 1194473
Total [baseline] (10.867 s) : 0, 10866914
Agent [candidate] (1.193 s) : 0, 1193373
Total [candidate] (10.99 s) : 0, 10989757
gantt
title petclinic - break down per module: candidate=1.60.0-SNAPSHOT~84ab56b1f9, baseline=1.60.0-SNAPSHOT~9c3d035f5f
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.192 ms) : 0, 1192
crashtracking [candidate] (1.187 ms) : 0, 1187
BytebuddyAgent [baseline] (628.058 ms) : 0, 628058
BytebuddyAgent [candidate] (629.014 ms) : 0, 629014
AgentMeter [baseline] (28.855 ms) : 0, 28855
AgentMeter [candidate] (28.853 ms) : 0, 28853
GlobalTracer [baseline] (257.551 ms) : 0, 257551
GlobalTracer [candidate] (258.247 ms) : 0, 258247
AppSec [baseline] (32.779 ms) : 0, 32779
AppSec [candidate] (32.773 ms) : 0, 32773
Debugger [baseline] (62.638 ms) : 0, 62638
Debugger [candidate] (61.773 ms) : 0, 61773
Remote Config [baseline] (630.239 µs) : 0, 630
Remote Config [candidate] (608.814 µs) : 0, 609
Telemetry [baseline] (12.37 ms) : 0, 12370
Telemetry [candidate] (12.395 ms) : 0, 12395
Flare Poller [baseline] (6.79 ms) : 0, 6790
Flare Poller [candidate] (6.2 ms) : 0, 6200
section appsec
crashtracking [baseline] (1.17 ms) : 0, 1170
crashtracking [candidate] (1.179 ms) : 0, 1179
BytebuddyAgent [baseline] (654.977 ms) : 0, 654977
BytebuddyAgent [candidate] (658.316 ms) : 0, 658316
AgentMeter [baseline] (11.795 ms) : 0, 11795
AgentMeter [candidate] (11.869 ms) : 0, 11869
GlobalTracer [baseline] (256.752 ms) : 0, 256752
GlobalTracer [candidate] (258.404 ms) : 0, 258404
AppSec [baseline] (167.254 ms) : 0, 167254
AppSec [candidate] (167.765 ms) : 0, 167765
Debugger [baseline] (67.001 ms) : 0, 67001
Debugger [candidate] (67.08 ms) : 0, 67080
Remote Config [baseline] (666.445 µs) : 0, 666
Remote Config [candidate] (667.273 µs) : 0, 667
Telemetry [baseline] (9.092 ms) : 0, 9092
Telemetry [candidate] (9.213 ms) : 0, 9213
Flare Poller [baseline] (3.601 ms) : 0, 3601
Flare Poller [candidate] (3.688 ms) : 0, 3688
IAST [baseline] (25.221 ms) : 0, 25221
IAST [candidate] (25.334 ms) : 0, 25334
section iast
crashtracking [baseline] (1.186 ms) : 0, 1186
crashtracking [candidate] (1.194 ms) : 0, 1194
BytebuddyAgent [baseline] (796.771 ms) : 0, 796771
BytebuddyAgent [candidate] (802.235 ms) : 0, 802235
AgentMeter [baseline] (11.256 ms) : 0, 11256
AgentMeter [candidate] (11.517 ms) : 0, 11517
GlobalTracer [baseline] (247.774 ms) : 0, 247774
GlobalTracer [candidate] (248.918 ms) : 0, 248918
AppSec [baseline] (34.839 ms) : 0, 34839
AppSec [candidate] (35.647 ms) : 0, 35647
Debugger [baseline] (65.237 ms) : 0, 65237
Debugger [candidate] (65.161 ms) : 0, 65161
Remote Config [baseline] (537.096 µs) : 0, 537
Remote Config [candidate] (552.055 µs) : 0, 552
Telemetry [baseline] (8.737 ms) : 0, 8737
Telemetry [candidate] (8.73 ms) : 0, 8730
Flare Poller [baseline] (3.44 ms) : 0, 3440
Flare Poller [candidate] (3.428 ms) : 0, 3428
IAST [baseline] (26.801 ms) : 0, 26801
IAST [candidate] (27.146 ms) : 0, 27146
section profiling
ProfilingAgent [baseline] (99.32 ms) : 0, 99320
ProfilingAgent [candidate] (99.996 ms) : 0, 99996
crashtracking [baseline] (1.219 ms) : 0, 1219
crashtracking [candidate] (1.214 ms) : 0, 1214
BytebuddyAgent [baseline] (685.612 ms) : 0, 685612
BytebuddyAgent [candidate] (682.962 ms) : 0, 682962
AgentMeter [baseline] (8.854 ms) : 0, 8854
AgentMeter [candidate] (8.748 ms) : 0, 8748
GlobalTracer [baseline] (215.763 ms) : 0, 215763
GlobalTracer [candidate] (216.598 ms) : 0, 216598
AppSec [baseline] (32.456 ms) : 0, 32456
AppSec [candidate] (32.776 ms) : 0, 32776
Debugger [baseline] (67.983 ms) : 0, 67983
Debugger [candidate] (68.026 ms) : 0, 68026
Remote Config [baseline] (602.32 µs) : 0, 602
Remote Config [candidate] (612.684 µs) : 0, 613
Telemetry [baseline] (8.817 ms) : 0, 8817
Telemetry [candidate] (8.828 ms) : 0, 8828
Flare Poller [baseline] (3.816 ms) : 0, 3816
Flare Poller [candidate] (3.784 ms) : 0, 3784
Profiling [baseline] (99.886 ms) : 0, 99886
Profiling [candidate] (100.57 ms) : 0, 100570
LoadParameters
See matching parameters
SummaryFound 3 performance improvements and 2 performance regressions! Performance is the same for 16 metrics, 15 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.60.0-SNAPSHOT~84ab56b1f9, baseline=1.60.0-SNAPSHOT~9c3d035f5f
dateFormat X
axisFormat %s
section baseline
no_agent (19.273 ms) : 19072, 19475
. : milestone, 19273,
appsec (18.597 ms) : 18407, 18788
. : milestone, 18597,
code_origins (17.649 ms) : 17473, 17824
. : milestone, 17649,
iast (17.753 ms) : 17578, 17927
. : milestone, 17753,
profiling (18.468 ms) : 18283, 18653
. : milestone, 18468,
tracing (17.755 ms) : 17578, 17932
. : milestone, 17755,
section candidate
no_agent (18.948 ms) : 18756, 19140
. : milestone, 18948,
appsec (19.514 ms) : 19315, 19712
. : milestone, 19514,
code_origins (17.538 ms) : 17363, 17712
. : milestone, 17538,
iast (17.609 ms) : 17432, 17785
. : milestone, 17609,
profiling (18.417 ms) : 18233, 18602
. : milestone, 18417,
tracing (17.348 ms) : 17180, 17516
. : milestone, 17348,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.60.0-SNAPSHOT~84ab56b1f9, baseline=1.60.0-SNAPSHOT~9c3d035f5f
dateFormat X
axisFormat %s
section baseline
no_agent (1.19 ms) : 1179, 1202
. : milestone, 1190,
iast (3.206 ms) : 3162, 3251
. : milestone, 3206,
iast_FULL (6.129 ms) : 6065, 6193
. : milestone, 6129,
iast_GLOBAL (3.563 ms) : 3497, 3628
. : milestone, 3563,
profiling (1.98 ms) : 1963, 1998
. : milestone, 1980,
tracing (1.769 ms) : 1754, 1783
. : milestone, 1769,
section candidate
no_agent (1.183 ms) : 1171, 1196
. : milestone, 1183,
iast (3.15 ms) : 3107, 3192
. : milestone, 3150,
iast_FULL (5.888 ms) : 5829, 5946
. : milestone, 5888,
iast_GLOBAL (3.585 ms) : 3525, 3644
. : milestone, 3585,
profiling (2.223 ms) : 2201, 2245
. : milestone, 2223,
tracing (1.754 ms) : 1739, 1768
. : milestone, 1754,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.60.0-SNAPSHOT~84ab56b1f9, baseline=1.60.0-SNAPSHOT~9c3d035f5f
dateFormat X
axisFormat %s
section baseline
no_agent (1.476 ms) : 1464, 1487
. : milestone, 1476,
appsec (2.502 ms) : 2447, 2556
. : milestone, 2502,
iast (2.253 ms) : 2184, 2322
. : milestone, 2253,
iast_GLOBAL (2.292 ms) : 2223, 2361
. : milestone, 2292,
profiling (2.107 ms) : 2050, 2163
. : milestone, 2107,
tracing (2.07 ms) : 2017, 2124
. : milestone, 2070,
section candidate
no_agent (1.477 ms) : 1465, 1489
. : milestone, 1477,
appsec (3.766 ms) : 3544, 3989
. : milestone, 3766,
iast (2.257 ms) : 2188, 2325
. : milestone, 2257,
iast_GLOBAL (2.307 ms) : 2237, 2376
. : milestone, 2307,
profiling (2.079 ms) : 2025, 2134
. : milestone, 2079,
tracing (2.065 ms) : 2012, 2118
. : milestone, 2065,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.60.0-SNAPSHOT~84ab56b1f9, baseline=1.60.0-SNAPSHOT~9c3d035f5f
dateFormat X
axisFormat %s
section baseline
no_agent (15.08 s) : 15080000, 15080000
. : milestone, 15080000,
appsec (15.135 s) : 15135000, 15135000
. : milestone, 15135000,
iast (17.918 s) : 17918000, 17918000
. : milestone, 17918000,
iast_GLOBAL (17.981 s) : 17981000, 17981000
. : milestone, 17981000,
profiling (14.871 s) : 14871000, 14871000
. : milestone, 14871000,
tracing (14.865 s) : 14865000, 14865000
. : milestone, 14865000,
section candidate
no_agent (15.126 s) : 15126000, 15126000
. : milestone, 15126000,
appsec (14.863 s) : 14863000, 14863000
. : milestone, 14863000,
iast (18.357 s) : 18357000, 18357000
. : milestone, 18357000,
iast_GLOBAL (17.951 s) : 17951000, 17951000
. : milestone, 17951000,
profiling (15.007 s) : 15007000, 15007000
. : milestone, 15007000,
tracing (14.601 s) : 14601000, 14601000
. : milestone, 14601000,
|
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
PR can't be merged according to github policy |
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
|
|
/merge |
|
View all feedbacks in Devflow UI.
PR already in the queue with status in_progress |
eff2a4b
into
master
What Does This Do
if an evaluation error is generated by a span decoration probe we are rate limiting it
Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: DEBUG-3797