-
Notifications
You must be signed in to change notification settings - Fork 324
Support histograms with explicit (non-negative) boundaries #10524
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support histograms with explicit (non-negative) boundaries #10524
Conversation
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 62 metrics, 9 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.60.0-SNAPSHOT~a8411c6cd7, baseline=1.60.0-SNAPSHOT~786c771187
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.066 s) : 0, 1065909
Total [baseline] (11.065 s) : 0, 11064799
Agent [candidate] (1.084 s) : 0, 1083571
Total [candidate] (10.996 s) : 0, 10996196
section appsec
Agent [baseline] (1.237 s) : 0, 1237407
Total [baseline] (11.093 s) : 0, 11092976
Agent [candidate] (1.24 s) : 0, 1239913
Total [candidate] (11.106 s) : 0, 11105961
section iast
Agent [baseline] (1.231 s) : 0, 1230964
Total [baseline] (11.188 s) : 0, 11188071
Agent [candidate] (1.235 s) : 0, 1234647
Total [candidate] (11.189 s) : 0, 11189336
section profiling
Agent [baseline] (1.195 s) : 0, 1194715
Total [baseline] (11.072 s) : 0, 11072112
Agent [candidate] (1.202 s) : 0, 1202407
Total [candidate] (11.041 s) : 0, 11040776
gantt
title petclinic - break down per module: candidate=1.60.0-SNAPSHOT~a8411c6cd7, baseline=1.60.0-SNAPSHOT~786c771187
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.18 ms) : 0, 1180
crashtracking [candidate] (1.206 ms) : 0, 1206
BytebuddyAgent [baseline] (628.376 ms) : 0, 628376
BytebuddyAgent [candidate] (638.43 ms) : 0, 638430
AgentMeter [baseline] (28.754 ms) : 0, 28754
AgentMeter [candidate] (29.363 ms) : 0, 29363
GlobalTracer [baseline] (258.308 ms) : 0, 258308
GlobalTracer [candidate] (261.917 ms) : 0, 261917
AppSec [baseline] (32.838 ms) : 0, 32838
AppSec [candidate] (33.835 ms) : 0, 33835
Debugger [baseline] (63.663 ms) : 0, 63663
Debugger [candidate] (61.906 ms) : 0, 61906
Remote Config [baseline] (619.308 µs) : 0, 619
Remote Config [candidate] (635.774 µs) : 0, 636
Telemetry [baseline] (12.223 ms) : 0, 12223
Telemetry [candidate] (11.713 ms) : 0, 11713
Flare Poller [baseline] (4.568 ms) : 0, 4568
Flare Poller [candidate] (8.823 ms) : 0, 8823
section appsec
crashtracking [baseline] (1.181 ms) : 0, 1181
crashtracking [candidate] (1.188 ms) : 0, 1188
BytebuddyAgent [baseline] (656.867 ms) : 0, 656867
BytebuddyAgent [candidate] (657.6 ms) : 0, 657600
AgentMeter [baseline] (11.757 ms) : 0, 11757
AgentMeter [candidate] (11.886 ms) : 0, 11886
GlobalTracer [baseline] (258.238 ms) : 0, 258238
GlobalTracer [candidate] (258.875 ms) : 0, 258875
IAST [baseline] (25.203 ms) : 0, 25203
IAST [candidate] (25.259 ms) : 0, 25259
AppSec [baseline] (167.766 ms) : 0, 167766
AppSec [candidate] (168.457 ms) : 0, 168457
Debugger [baseline] (67.435 ms) : 0, 67435
Debugger [candidate] (67.609 ms) : 0, 67609
Remote Config [baseline] (680.362 µs) : 0, 680
Remote Config [candidate] (691.913 µs) : 0, 692
Telemetry [baseline] (9.237 ms) : 0, 9237
Telemetry [candidate] (9.242 ms) : 0, 9242
Flare Poller [baseline] (3.704 ms) : 0, 3704
Flare Poller [candidate] (3.668 ms) : 0, 3668
section iast
crashtracking [baseline] (1.196 ms) : 0, 1196
crashtracking [candidate] (1.215 ms) : 0, 1215
BytebuddyAgent [baseline] (795.508 ms) : 0, 795508
BytebuddyAgent [candidate] (797.486 ms) : 0, 797486
AgentMeter [baseline] (11.118 ms) : 0, 11118
AgentMeter [candidate] (11.271 ms) : 0, 11271
GlobalTracer [baseline] (247.871 ms) : 0, 247871
GlobalTracer [candidate] (248.344 ms) : 0, 248344
IAST [baseline] (26.786 ms) : 0, 26786
IAST [candidate] (26.783 ms) : 0, 26783
AppSec [baseline] (32.263 ms) : 0, 32263
AppSec [candidate] (33.126 ms) : 0, 33126
Debugger [baseline] (68.225 ms) : 0, 68225
Debugger [candidate] (68.319 ms) : 0, 68319
Remote Config [baseline] (546.472 µs) : 0, 546
Remote Config [candidate] (541.278 µs) : 0, 541
Telemetry [baseline] (8.644 ms) : 0, 8644
Telemetry [candidate] (8.73 ms) : 0, 8730
Flare Poller [baseline] (3.44 ms) : 0, 3440
Flare Poller [candidate] (3.473 ms) : 0, 3473
section profiling
crashtracking [baseline] (1.219 ms) : 0, 1219
crashtracking [candidate] (1.227 ms) : 0, 1227
BytebuddyAgent [baseline] (684.629 ms) : 0, 684629
BytebuddyAgent [candidate] (688.489 ms) : 0, 688489
AgentMeter [baseline] (8.772 ms) : 0, 8772
AgentMeter [candidate] (8.842 ms) : 0, 8842
GlobalTracer [baseline] (216.398 ms) : 0, 216398
GlobalTracer [candidate] (218.204 ms) : 0, 218204
AppSec [baseline] (32.614 ms) : 0, 32614
AppSec [candidate] (32.891 ms) : 0, 32891
Debugger [baseline] (67.877 ms) : 0, 67877
Debugger [candidate] (68.642 ms) : 0, 68642
Remote Config [baseline] (601.436 µs) : 0, 601
Remote Config [candidate] (607.569 µs) : 0, 608
Telemetry [baseline] (8.835 ms) : 0, 8835
Telemetry [candidate] (8.865 ms) : 0, 8865
Flare Poller [baseline] (3.795 ms) : 0, 3795
Flare Poller [candidate] (3.789 ms) : 0, 3789
ProfilingAgent [baseline] (100.02 ms) : 0, 100020
ProfilingAgent [candidate] (100.414 ms) : 0, 100414
Profiling [baseline] (100.593 ms) : 0, 100593
Profiling [candidate] (100.997 ms) : 0, 100997
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.60.0-SNAPSHOT~a8411c6cd7, baseline=1.60.0-SNAPSHOT~786c771187
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.066 s) : 0, 1065850
Total [baseline] (8.76 s) : 0, 8759599
Agent [candidate] (1.063 s) : 0, 1062995
Total [candidate] (8.757 s) : 0, 8757445
section iast
Agent [baseline] (1.232 s) : 0, 1232068
Total [baseline] (9.401 s) : 0, 9401418
Agent [candidate] (1.23 s) : 0, 1229779
Total [candidate] (9.353 s) : 0, 9353489
gantt
title insecure-bank - break down per module: candidate=1.60.0-SNAPSHOT~a8411c6cd7, baseline=1.60.0-SNAPSHOT~786c771187
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.182 ms) : 0, 1182
crashtracking [candidate] (1.181 ms) : 0, 1181
BytebuddyAgent [baseline] (628.987 ms) : 0, 628987
BytebuddyAgent [candidate] (627.157 ms) : 0, 627157
AgentMeter [baseline] (28.74 ms) : 0, 28740
AgentMeter [candidate] (28.812 ms) : 0, 28812
GlobalTracer [baseline] (258.07 ms) : 0, 258070
GlobalTracer [candidate] (257.763 ms) : 0, 257763
AppSec [baseline] (32.94 ms) : 0, 32940
AppSec [candidate] (32.696 ms) : 0, 32696
Debugger [baseline] (61.308 ms) : 0, 61308
Debugger [candidate] (63.294 ms) : 0, 63294
Remote Config [baseline] (622.847 µs) : 0, 623
Remote Config [candidate] (614.615 µs) : 0, 615
Telemetry [baseline] (14.038 ms) : 0, 14038
Telemetry [candidate] (10.587 ms) : 0, 10587
Flare Poller [baseline] (4.57 ms) : 0, 4570
Flare Poller [candidate] (5.472 ms) : 0, 5472
section iast
crashtracking [baseline] (1.184 ms) : 0, 1184
crashtracking [candidate] (1.185 ms) : 0, 1185
BytebuddyAgent [baseline] (796.409 ms) : 0, 796409
BytebuddyAgent [candidate] (795.717 ms) : 0, 795717
AgentMeter [baseline] (11.179 ms) : 0, 11179
AgentMeter [candidate] (11.236 ms) : 0, 11236
GlobalTracer [baseline] (248.362 ms) : 0, 248362
GlobalTracer [candidate] (247.345 ms) : 0, 247345
IAST [baseline] (26.933 ms) : 0, 26933
IAST [candidate] (26.956 ms) : 0, 26956
AppSec [baseline] (33.963 ms) : 0, 33963
AppSec [candidate] (33.824 ms) : 0, 33824
Debugger [baseline] (65.839 ms) : 0, 65839
Debugger [candidate] (65.549 ms) : 0, 65549
Remote Config [baseline] (547.588 µs) : 0, 548
Remote Config [candidate] (547.256 µs) : 0, 547
Telemetry [baseline] (8.754 ms) : 0, 8754
Telemetry [candidate] (8.653 ms) : 0, 8653
Flare Poller [baseline] (3.505 ms) : 0, 3505
Flare Poller [candidate] (3.465 ms) : 0, 3465
LoadParameters
See matching parameters
SummaryFound 1 performance improvements and 2 performance regressions! Performance is the same for 17 metrics, 16 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.60.0-SNAPSHOT~a8411c6cd7, baseline=1.60.0-SNAPSHOT~786c771187
dateFormat X
axisFormat %s
section baseline
no_agent (1.176 ms) : 1164, 1188
. : milestone, 1176,
iast (3.314 ms) : 3267, 3362
. : milestone, 3314,
iast_FULL (5.8 ms) : 5743, 5857
. : milestone, 5800,
iast_GLOBAL (3.656 ms) : 3590, 3722
. : milestone, 3656,
profiling (2.133 ms) : 2113, 2154
. : milestone, 2133,
tracing (1.862 ms) : 1845, 1879
. : milestone, 1862,
section candidate
no_agent (1.197 ms) : 1185, 1209
. : milestone, 1197,
iast (3.263 ms) : 3217, 3309
. : milestone, 3263,
iast_FULL (5.955 ms) : 5895, 6014
. : milestone, 5955,
iast_GLOBAL (3.519 ms) : 3469, 3569
. : milestone, 3519,
profiling (2.02 ms) : 2001, 2039
. : milestone, 2020,
tracing (1.781 ms) : 1766, 1795
. : milestone, 1781,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.60.0-SNAPSHOT~a8411c6cd7, baseline=1.60.0-SNAPSHOT~786c771187
dateFormat X
axisFormat %s
section baseline
no_agent (18.11 ms) : 17926, 18295
. : milestone, 18110,
appsec (19.477 ms) : 19278, 19676
. : milestone, 19477,
code_origins (17.571 ms) : 17396, 17747
. : milestone, 17571,
iast (17.606 ms) : 17432, 17780
. : milestone, 17606,
profiling (18.577 ms) : 18393, 18762
. : milestone, 18577,
tracing (17.715 ms) : 17543, 17888
. : milestone, 17715,
section candidate
no_agent (18.006 ms) : 17821, 18192
. : milestone, 18006,
appsec (18.708 ms) : 18515, 18901
. : milestone, 18708,
code_origins (17.779 ms) : 17602, 17957
. : milestone, 17779,
iast (17.58 ms) : 17403, 17757
. : milestone, 17580,
profiling (18.661 ms) : 18481, 18842
. : milestone, 18661,
tracing (18.755 ms) : 18566, 18943
. : milestone, 18755,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.60.0-SNAPSHOT~a8411c6cd7, baseline=1.60.0-SNAPSHOT~786c771187
dateFormat X
axisFormat %s
section baseline
no_agent (15.064 s) : 15064000, 15064000
. : milestone, 15064000,
appsec (14.839 s) : 14839000, 14839000
. : milestone, 14839000,
iast (18.09 s) : 18090000, 18090000
. : milestone, 18090000,
iast_GLOBAL (17.834 s) : 17834000, 17834000
. : milestone, 17834000,
profiling (15.487 s) : 15487000, 15487000
. : milestone, 15487000,
tracing (14.704 s) : 14704000, 14704000
. : milestone, 14704000,
section candidate
no_agent (14.931 s) : 14931000, 14931000
. : milestone, 14931000,
appsec (14.96 s) : 14960000, 14960000
. : milestone, 14960000,
iast (18.225 s) : 18225000, 18225000
. : milestone, 18225000,
iast_GLOBAL (18.064 s) : 18064000, 18064000
. : milestone, 18064000,
profiling (14.856 s) : 14856000, 14856000
. : milestone, 14856000,
tracing (14.589 s) : 14589000, 14589000
. : milestone, 14589000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.60.0-SNAPSHOT~a8411c6cd7, baseline=1.60.0-SNAPSHOT~786c771187
dateFormat X
axisFormat %s
section baseline
no_agent (1.472 ms) : 1461, 1484
. : milestone, 1472,
appsec (3.765 ms) : 3546, 3984
. : milestone, 3765,
iast (2.24 ms) : 2171, 2308
. : milestone, 2240,
iast_GLOBAL (2.294 ms) : 2225, 2363
. : milestone, 2294,
profiling (2.088 ms) : 2032, 2144
. : milestone, 2088,
tracing (2.048 ms) : 1995, 2101
. : milestone, 2048,
section candidate
no_agent (1.477 ms) : 1465, 1488
. : milestone, 1477,
appsec (3.746 ms) : 3526, 3965
. : milestone, 3746,
iast (2.246 ms) : 2178, 2314
. : milestone, 2246,
iast_GLOBAL (2.29 ms) : 2221, 2359
. : milestone, 2290,
profiling (2.072 ms) : 2017, 2126
. : milestone, 2072,
tracing (2.057 ms) : 2004, 2110
. : milestone, 2057,
|
dougqh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wish we didn't have the List, so we could avoid boxing.
But I suspect the overhead is okay here
Agreed, we're somewhat limited by the OTel API which uses
In most cases the incoming list will be the same default boundaries, and the returned values only exist for a short time in order to snapshot + export the periodic data. So the overhead should be limited. |
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
|
13d10a0
into
master
|
Nice addition. |
Motivation
We need this to support explicit histogram boundaries in the OpenTelemetry metrics API
Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: APMAPI-1764