-
Notifications
You must be signed in to change notification settings - Fork 324
Fix Exception Replay in Lambda #10505
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Exception Replay in Lambda #10505
Conversation
In Lambda, the inner stack trace is truncated -- stack frames from fileName='AWSLambda.java' are removed. Therefore, in the original code, we would end up with a negative currentIdx, resulting in an error occurring in sanityCheckSnapshotAssignment. This PR adds a fallback to fix the mismatched pointer.
Debugger benchmarksParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 9 metrics, 6 unstable metrics. See unchanged results
Request duration reports for reportsgantt
title reports - request duration [CI 0.99] : candidate=None, baseline=None
dateFormat X
axisFormat %s
section baseline
noprobe (333.223 µs) : 265, 401
. : milestone, 333,
basic (276.261 µs) : 266, 286
. : milestone, 276,
loop (8.951 ms) : 8944, 8958
. : milestone, 8951,
section candidate
noprobe (314.099 µs) : 282, 347
. : milestone, 314,
basic (274.176 µs) : 268, 280
. : milestone, 274,
loop (8.955 ms) : 8950, 8961
. : milestone, 8955,
|
BenchmarksStartupParameters
See matching parameters
SummaryFound 1 performance improvements and 0 performance regressions! Performance is the same for 63 metrics, 7 unstable metrics.
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.59.0-SNAPSHOT~b4f4a4789b, baseline=1.59.0-SNAPSHOT~482bd1e95c
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.074 s) : 0, 1073621
Total [baseline] (10.819 s) : 0, 10819082
Agent [candidate] (1.065 s) : 0, 1065216
Total [candidate] (10.911 s) : 0, 10911224
section appsec
Agent [baseline] (1.241 s) : 0, 1241229
Total [baseline] (11.065 s) : 0, 11064611
Agent [candidate] (1.244 s) : 0, 1244072
Total [candidate] (10.961 s) : 0, 10961154
section iast
Agent [baseline] (1.231 s) : 0, 1231048
Total [baseline] (11.267 s) : 0, 11267108
Agent [candidate] (1.24 s) : 0, 1239873
Total [candidate] (11.292 s) : 0, 11292154
section profiling
Agent [baseline] (1.193 s) : 0, 1193447
Total [baseline] (11.021 s) : 0, 11020535
Agent [candidate] (1.193 s) : 0, 1193084
Total [candidate] (11.022 s) : 0, 11021886
gantt
title petclinic - break down per module: candidate=1.59.0-SNAPSHOT~b4f4a4789b, baseline=1.59.0-SNAPSHOT~482bd1e95c
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.199 ms) : 0, 1199
crashtracking [candidate] (1.189 ms) : 0, 1189
BytebuddyAgent [baseline] (633.287 ms) : 0, 633287
BytebuddyAgent [candidate] (627.989 ms) : 0, 627989
AgentMeter [baseline] (28.971 ms) : 0, 28971
AgentMeter [candidate] (28.73 ms) : 0, 28730
GlobalTracer [baseline] (259.648 ms) : 0, 259648
GlobalTracer [candidate] (258.298 ms) : 0, 258298
AppSec [baseline] (33.098 ms) : 0, 33098
AppSec [candidate] (32.857 ms) : 0, 32857
Debugger [baseline] (61.654 ms) : 0, 61654
Debugger [candidate] (64.266 ms) : 0, 64266
Remote Config [baseline] (632.609 µs) : 0, 633
Remote Config [candidate] (600.396 µs) : 0, 600
Telemetry [baseline] (12.51 ms) : 0, 12510
Telemetry [candidate] (10.658 ms) : 0, 10658
Flare Poller [baseline] (6.953 ms) : 0, 6953
Flare Poller [candidate] (5.267 ms) : 0, 5267
section appsec
crashtracking [baseline] (1.186 ms) : 0, 1186
crashtracking [candidate] (1.188 ms) : 0, 1188
BytebuddyAgent [baseline] (658.81 ms) : 0, 658810
BytebuddyAgent [candidate] (661.183 ms) : 0, 661183
AgentMeter [baseline] (11.77 ms) : 0, 11770
AgentMeter [candidate] (11.872 ms) : 0, 11872
GlobalTracer [baseline] (259.01 ms) : 0, 259010
GlobalTracer [candidate] (260.023 ms) : 0, 260023
IAST [baseline] (25.457 ms) : 0, 25457
IAST [candidate] (25.544 ms) : 0, 25544
AppSec [baseline] (169.241 ms) : 0, 169241
AppSec [candidate] (167.985 ms) : 0, 167985
Debugger [baseline] (66.659 ms) : 0, 66659
Debugger [candidate] (67.279 ms) : 0, 67279
Remote Config [baseline] (674.346 µs) : 0, 674
Remote Config [candidate] (675.532 µs) : 0, 676
Telemetry [baseline] (9.226 ms) : 0, 9226
Telemetry [candidate] (9.187 ms) : 0, 9187
Flare Poller [baseline] (3.695 ms) : 0, 3695
Flare Poller [candidate] (3.633 ms) : 0, 3633
section iast
crashtracking [baseline] (1.192 ms) : 0, 1192
crashtracking [candidate] (1.188 ms) : 0, 1188
BytebuddyAgent [baseline] (794.912 ms) : 0, 794912
BytebuddyAgent [candidate] (800.546 ms) : 0, 800546
AgentMeter [baseline] (11.111 ms) : 0, 11111
AgentMeter [candidate] (11.276 ms) : 0, 11276
GlobalTracer [baseline] (247.744 ms) : 0, 247744
GlobalTracer [candidate] (250.182 ms) : 0, 250182
IAST [baseline] (27.01 ms) : 0, 27010
IAST [candidate] (27.322 ms) : 0, 27322
AppSec [baseline] (34.717 ms) : 0, 34717
AppSec [candidate] (35.579 ms) : 0, 35579
Debugger [baseline] (66.178 ms) : 0, 66178
Debugger [candidate] (65.459 ms) : 0, 65459
Remote Config [baseline] (564.774 µs) : 0, 565
Remote Config [candidate] (568.066 µs) : 0, 568
Telemetry [baseline] (8.772 ms) : 0, 8772
Telemetry [candidate] (8.844 ms) : 0, 8844
Flare Poller [baseline] (3.482 ms) : 0, 3482
Flare Poller [candidate] (3.532 ms) : 0, 3532
section profiling
crashtracking [baseline] (1.219 ms) : 0, 1219
crashtracking [candidate] (1.216 ms) : 0, 1216
BytebuddyAgent [baseline] (682.96 ms) : 0, 682960
BytebuddyAgent [candidate] (683.213 ms) : 0, 683213
AgentMeter [baseline] (8.649 ms) : 0, 8649
AgentMeter [candidate] (8.679 ms) : 0, 8679
GlobalTracer [baseline] (216.706 ms) : 0, 216706
GlobalTracer [candidate] (216.631 ms) : 0, 216631
AppSec [baseline] (32.662 ms) : 0, 32662
AppSec [candidate] (32.511 ms) : 0, 32511
Debugger [baseline] (68.192 ms) : 0, 68192
Debugger [candidate] (67.681 ms) : 0, 67681
Remote Config [baseline] (613.875 µs) : 0, 614
Remote Config [candidate] (604.757 µs) : 0, 605
Telemetry [baseline] (8.786 ms) : 0, 8786
Telemetry [candidate] (8.803 ms) : 0, 8803
Flare Poller [baseline] (3.744 ms) : 0, 3744
Flare Poller [candidate] (3.813 ms) : 0, 3813
ProfilingAgent [baseline] (99.808 ms) : 0, 99808
ProfilingAgent [candidate] (99.987 ms) : 0, 99987
Profiling [baseline] (100.388 ms) : 0, 100388
Profiling [candidate] (100.572 ms) : 0, 100572
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.59.0-SNAPSHOT~b4f4a4789b, baseline=1.59.0-SNAPSHOT~482bd1e95c
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.067 s) : 0, 1067069
Total [baseline] (8.78 s) : 0, 8780036
Agent [candidate] (1.071 s) : 0, 1071208
Total [candidate] (8.756 s) : 0, 8756230
section iast
Agent [baseline] (1.247 s) : 0, 1246932
Total [baseline] (9.45 s) : 0, 9449977
Agent [candidate] (1.229 s) : 0, 1228876
Total [candidate] (9.373 s) : 0, 9372605
gantt
title insecure-bank - break down per module: candidate=1.59.0-SNAPSHOT~b4f4a4789b, baseline=1.59.0-SNAPSHOT~482bd1e95c
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.193 ms) : 0, 1193
crashtracking [candidate] (1.194 ms) : 0, 1194
BytebuddyAgent [baseline] (627.931 ms) : 0, 627931
BytebuddyAgent [candidate] (632.714 ms) : 0, 632714
AgentMeter [baseline] (29.012 ms) : 0, 29012
AgentMeter [candidate] (28.967 ms) : 0, 28967
GlobalTracer [baseline] (259.056 ms) : 0, 259056
GlobalTracer [candidate] (259.513 ms) : 0, 259513
AppSec [baseline] (32.97 ms) : 0, 32970
AppSec [candidate] (33.145 ms) : 0, 33145
Debugger [baseline] (61.509 ms) : 0, 61509
Debugger [candidate] (60.876 ms) : 0, 60876
Remote Config [baseline] (626.005 µs) : 0, 626
Remote Config [candidate] (623.017 µs) : 0, 623
Telemetry [baseline] (12.419 ms) : 0, 12419
Telemetry [candidate] (13.237 ms) : 0, 13237
Flare Poller [baseline] (6.879 ms) : 0, 6879
Flare Poller [candidate] (5.363 ms) : 0, 5363
section iast
crashtracking [baseline] (1.203 ms) : 0, 1203
crashtracking [candidate] (1.194 ms) : 0, 1194
BytebuddyAgent [baseline] (805.599 ms) : 0, 805599
BytebuddyAgent [candidate] (794.543 ms) : 0, 794543
AgentMeter [baseline] (11.354 ms) : 0, 11354
AgentMeter [candidate] (11.135 ms) : 0, 11135
GlobalTracer [baseline] (250.493 ms) : 0, 250493
GlobalTracer [candidate] (247.709 ms) : 0, 247709
IAST [baseline] (27.402 ms) : 0, 27402
IAST [candidate] (26.936 ms) : 0, 26936
AppSec [baseline] (34.027 ms) : 0, 34027
AppSec [candidate] (33.077 ms) : 0, 33077
Debugger [baseline] (68.016 ms) : 0, 68016
Debugger [candidate] (66.173 ms) : 0, 66173
Remote Config [baseline] (559.392 µs) : 0, 559
Remote Config [candidate] (543.363 µs) : 0, 543
Telemetry [baseline] (8.882 ms) : 0, 8882
Telemetry [candidate] (8.721 ms) : 0, 8721
Flare Poller [baseline] (3.606 ms) : 0, 3606
Flare Poller [candidate] (3.535 ms) : 0, 3535
LoadParameters
See matching parameters
SummaryFound 2 performance improvements and 0 performance regressions! Performance is the same for 19 metrics, 15 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.59.0-SNAPSHOT~b4f4a4789b, baseline=1.59.0-SNAPSHOT~482bd1e95c
dateFormat X
axisFormat %s
section baseline
no_agent (19.179 ms) : 18980, 19378
. : milestone, 19179,
appsec (18.67 ms) : 18483, 18857
. : milestone, 18670,
code_origins (17.462 ms) : 17291, 17634
. : milestone, 17462,
iast (18.481 ms) : 18296, 18666
. : milestone, 18481,
profiling (18.938 ms) : 18750, 19127
. : milestone, 18938,
tracing (17.397 ms) : 17224, 17571
. : milestone, 17397,
section candidate
no_agent (18.816 ms) : 18627, 19006
. : milestone, 18816,
appsec (18.653 ms) : 18462, 18844
. : milestone, 18653,
code_origins (17.668 ms) : 17494, 17843
. : milestone, 17668,
iast (17.468 ms) : 17295, 17641
. : milestone, 17468,
profiling (18.748 ms) : 18556, 18940
. : milestone, 18748,
tracing (17.594 ms) : 17418, 17770
. : milestone, 17594,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.59.0-SNAPSHOT~b4f4a4789b, baseline=1.59.0-SNAPSHOT~482bd1e95c
dateFormat X
axisFormat %s
section baseline
no_agent (1.167 ms) : 1156, 1178
. : milestone, 1167,
iast (3.147 ms) : 3103, 3192
. : milestone, 3147,
iast_FULL (5.635 ms) : 5579, 5691
. : milestone, 5635,
iast_GLOBAL (3.426 ms) : 3374, 3477
. : milestone, 3426,
profiling (2.422 ms) : 2398, 2446
. : milestone, 2422,
tracing (1.796 ms) : 1781, 1810
. : milestone, 1796,
section candidate
no_agent (1.175 ms) : 1164, 1186
. : milestone, 1175,
iast (3.228 ms) : 3181, 3274
. : milestone, 3228,
iast_FULL (5.686 ms) : 5630, 5743
. : milestone, 5686,
iast_GLOBAL (3.41 ms) : 3364, 3456
. : milestone, 3410,
profiling (2.085 ms) : 2067, 2104
. : milestone, 2085,
tracing (1.806 ms) : 1792, 1821
. : milestone, 1806,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.59.0-SNAPSHOT~b4f4a4789b, baseline=1.59.0-SNAPSHOT~482bd1e95c
dateFormat X
axisFormat %s
section baseline
no_agent (1.472 ms) : 1460, 1483
. : milestone, 1472,
appsec (2.548 ms) : 2490, 2606
. : milestone, 2548,
iast (2.248 ms) : 2179, 2317
. : milestone, 2248,
iast_GLOBAL (2.292 ms) : 2222, 2361
. : milestone, 2292,
profiling (2.074 ms) : 2020, 2129
. : milestone, 2074,
tracing (2.061 ms) : 2007, 2114
. : milestone, 2061,
section candidate
no_agent (1.471 ms) : 1460, 1483
. : milestone, 1471,
appsec (2.486 ms) : 2431, 2540
. : milestone, 2486,
iast (2.246 ms) : 2177, 2315
. : milestone, 2246,
iast_GLOBAL (2.291 ms) : 2222, 2360
. : milestone, 2291,
profiling (2.115 ms) : 2058, 2172
. : milestone, 2115,
tracing (2.052 ms) : 1999, 2106
. : milestone, 2052,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.59.0-SNAPSHOT~b4f4a4789b, baseline=1.59.0-SNAPSHOT~482bd1e95c
dateFormat X
axisFormat %s
section baseline
no_agent (15.256 s) : 15256000, 15256000
. : milestone, 15256000,
appsec (14.866 s) : 14866000, 14866000
. : milestone, 14866000,
iast (18.047 s) : 18047000, 18047000
. : milestone, 18047000,
iast_GLOBAL (17.875 s) : 17875000, 17875000
. : milestone, 17875000,
profiling (14.635 s) : 14635000, 14635000
. : milestone, 14635000,
tracing (15.15 s) : 15150000, 15150000
. : milestone, 15150000,
section candidate
no_agent (14.724 s) : 14724000, 14724000
. : milestone, 14724000,
appsec (14.585 s) : 14585000, 14585000
. : milestone, 14585000,
iast (18.584 s) : 18584000, 18584000
. : milestone, 18584000,
iast_GLOBAL (17.847 s) : 17847000, 17847000
. : milestone, 17847000,
profiling (14.746 s) : 14746000, 14746000
. : milestone, 14746000,
tracing (14.996 s) : 14996000, 14996000
. : milestone, 14996000,
|
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
|
2ffa640
into
master
What Does This Do
In Lambda, the inner stack trace is truncated -- stack frames from fileName='AWSLambda.java' are removed. Therefore, in the original code, we would end up with a negative currentIdx, resulting in an error occurring in sanityCheckSnapshotAssignment. This PR adds a fallback to fix the mismatched pointer.
Motivation
SVLS-6855
Additional Notes
Related to #10380 & #8849
Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: SVLS-6855