-
Notifications
You must be signed in to change notification settings - Fork 324
Fix Exception Replay in Lambda #10380
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Exception Replay in Lambda #10380
Conversation
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 61 metrics, 10 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.59.0-SNAPSHOT~28b6ab4d16, baseline=1.59.0-SNAPSHOT~7b4f50cd76
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.06 s) : 0, 1059587
Total [baseline] (8.717 s) : 0, 8717073
Agent [candidate] (1.055 s) : 0, 1055407
Total [candidate] (8.666 s) : 0, 8665670
section iast
Agent [baseline] (1.232 s) : 0, 1231625
Total [baseline] (9.348 s) : 0, 9347809
Agent [candidate] (1.224 s) : 0, 1223624
Total [candidate] (9.359 s) : 0, 9358870
gantt
title insecure-bank - break down per module: candidate=1.59.0-SNAPSHOT~28b6ab4d16, baseline=1.59.0-SNAPSHOT~7b4f50cd76
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.2 ms) : 0, 1200
crashtracking [candidate] (1.172 ms) : 0, 1172
BytebuddyAgent [baseline] (626.212 ms) : 0, 626212
BytebuddyAgent [candidate] (621.704 ms) : 0, 621704
AgentMeter [baseline] (28.937 ms) : 0, 28937
AgentMeter [candidate] (28.627 ms) : 0, 28627
GlobalTracer [baseline] (256.291 ms) : 0, 256291
GlobalTracer [candidate] (256.368 ms) : 0, 256368
AppSec [baseline] (32.664 ms) : 0, 32664
AppSec [candidate] (32.539 ms) : 0, 32539
Debugger [baseline] (60.729 ms) : 0, 60729
Debugger [candidate] (60.606 ms) : 0, 60606
Remote Config [baseline] (613.095 µs) : 0, 613
Remote Config [candidate] (626.017 µs) : 0, 626
Telemetry [baseline] (10.619 ms) : 0, 10619
Telemetry [candidate] (9.829 ms) : 0, 9829
Flare Poller [baseline] (6.863 ms) : 0, 6863
Flare Poller [candidate] (8.459 ms) : 0, 8459
section iast
crashtracking [baseline] (1.195 ms) : 0, 1195
crashtracking [candidate] (1.189 ms) : 0, 1189
BytebuddyAgent [baseline] (795.46 ms) : 0, 795460
BytebuddyAgent [candidate] (789.652 ms) : 0, 789652
AgentMeter [baseline] (11.372 ms) : 0, 11372
AgentMeter [candidate] (11.149 ms) : 0, 11149
GlobalTracer [baseline] (248.661 ms) : 0, 248661
GlobalTracer [candidate] (247.434 ms) : 0, 247434
IAST [baseline] (26.96 ms) : 0, 26960
IAST [candidate] (26.775 ms) : 0, 26775
AppSec [baseline] (34.912 ms) : 0, 34912
AppSec [candidate] (32.337 ms) : 0, 32337
Debugger [baseline] (65.14 ms) : 0, 65140
Debugger [candidate] (67.107 ms) : 0, 67107
Remote Config [baseline] (547.821 µs) : 0, 548
Remote Config [candidate] (535.749 µs) : 0, 536
Telemetry [baseline] (8.452 ms) : 0, 8452
Telemetry [candidate] (8.422 ms) : 0, 8422
Flare Poller [baseline] (3.436 ms) : 0, 3436
Flare Poller [candidate] (3.527 ms) : 0, 3527
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.59.0-SNAPSHOT~28b6ab4d16, baseline=1.59.0-SNAPSHOT~7b4f50cd76
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.064 s) : 0, 1064301
Total [baseline] (11.055 s) : 0, 11054584
Agent [candidate] (1.053 s) : 0, 1052982
Total [candidate] (10.905 s) : 0, 10904981
section appsec
Agent [baseline] (1.232 s) : 0, 1231886
Total [baseline] (10.93 s) : 0, 10929989
Agent [candidate] (1.235 s) : 0, 1235296
Total [candidate] (10.899 s) : 0, 10899116
section iast
Agent [baseline] (1.233 s) : 0, 1233172
Total [baseline] (11.147 s) : 0, 11146919
Agent [candidate] (1.227 s) : 0, 1226969
Total [candidate] (11.159 s) : 0, 11158798
section profiling
Agent [baseline] (1.183 s) : 0, 1183467
Total [baseline] (10.757 s) : 0, 10756824
Agent [candidate] (1.193 s) : 0, 1192532
Total [candidate] (10.962 s) : 0, 10961688
gantt
title petclinic - break down per module: candidate=1.59.0-SNAPSHOT~28b6ab4d16, baseline=1.59.0-SNAPSHOT~7b4f50cd76
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.192 ms) : 0, 1192
crashtracking [candidate] (1.206 ms) : 0, 1206
BytebuddyAgent [baseline] (626.145 ms) : 0, 626145
BytebuddyAgent [candidate] (620.52 ms) : 0, 620520
AgentMeter [baseline] (28.952 ms) : 0, 28952
AgentMeter [candidate] (28.637 ms) : 0, 28637
GlobalTracer [baseline] (258.245 ms) : 0, 258245
GlobalTracer [candidate] (256.232 ms) : 0, 256232
AppSec [baseline] (33.104 ms) : 0, 33104
AppSec [candidate] (32.555 ms) : 0, 32555
Debugger [baseline] (62.919 ms) : 0, 62919
Debugger [candidate] (60.219 ms) : 0, 60219
Remote Config [baseline] (619.818 µs) : 0, 620
Remote Config [candidate] (617.682 µs) : 0, 618
Telemetry [baseline] (9.236 ms) : 0, 9236
Telemetry [candidate] (9.862 ms) : 0, 9862
Flare Poller [baseline] (8.582 ms) : 0, 8582
Flare Poller [candidate] (7.808 ms) : 0, 7808
section appsec
crashtracking [baseline] (1.185 ms) : 0, 1185
crashtracking [candidate] (1.178 ms) : 0, 1178
BytebuddyAgent [baseline] (652.696 ms) : 0, 652696
BytebuddyAgent [candidate] (654.587 ms) : 0, 654587
AgentMeter [baseline] (11.8 ms) : 0, 11800
AgentMeter [candidate] (11.834 ms) : 0, 11834
GlobalTracer [baseline] (257.196 ms) : 0, 257196
GlobalTracer [candidate] (258.043 ms) : 0, 258043
IAST [baseline] (25.293 ms) : 0, 25293
IAST [candidate] (25.602 ms) : 0, 25602
AppSec [baseline] (167.479 ms) : 0, 167479
AppSec [candidate] (167.717 ms) : 0, 167717
Debugger [baseline] (67.396 ms) : 0, 67396
Debugger [candidate] (67.477 ms) : 0, 67477
Remote Config [baseline] (654.186 µs) : 0, 654
Remote Config [candidate] (678.994 µs) : 0, 679
Telemetry [baseline] (9.157 ms) : 0, 9157
Telemetry [candidate] (9.253 ms) : 0, 9253
Flare Poller [baseline] (3.604 ms) : 0, 3604
Flare Poller [candidate] (3.636 ms) : 0, 3636
section iast
crashtracking [baseline] (1.182 ms) : 0, 1182
crashtracking [candidate] (1.182 ms) : 0, 1182
BytebuddyAgent [baseline] (794.56 ms) : 0, 794560
BytebuddyAgent [candidate] (790.762 ms) : 0, 790762
AgentMeter [baseline] (11.415 ms) : 0, 11415
AgentMeter [candidate] (11.191 ms) : 0, 11191
GlobalTracer [baseline] (248.748 ms) : 0, 248748
GlobalTracer [candidate] (247.941 ms) : 0, 247941
IAST [baseline] (27.105 ms) : 0, 27105
IAST [candidate] (26.848 ms) : 0, 26848
AppSec [baseline] (30.67 ms) : 0, 30670
AppSec [candidate] (32.194 ms) : 0, 32194
Debugger [baseline] (71.271 ms) : 0, 71271
Debugger [candidate] (68.806 ms) : 0, 68806
Remote Config [baseline] (552.943 µs) : 0, 553
Remote Config [candidate] (556.759 µs) : 0, 557
Telemetry [baseline] (8.645 ms) : 0, 8645
Telemetry [candidate] (8.666 ms) : 0, 8666
Flare Poller [baseline] (3.575 ms) : 0, 3575
Flare Poller [candidate] (3.509 ms) : 0, 3509
section profiling
crashtracking [baseline] (1.214 ms) : 0, 1214
crashtracking [candidate] (1.216 ms) : 0, 1216
BytebuddyAgent [baseline] (676.326 ms) : 0, 676326
BytebuddyAgent [candidate] (681.963 ms) : 0, 681963
AgentMeter [baseline] (8.621 ms) : 0, 8621
AgentMeter [candidate] (8.715 ms) : 0, 8715
GlobalTracer [baseline] (216.527 ms) : 0, 216527
GlobalTracer [candidate] (217.579 ms) : 0, 217579
AppSec [baseline] (32.078 ms) : 0, 32078
AppSec [candidate] (32.381 ms) : 0, 32381
Debugger [baseline] (67.612 ms) : 0, 67612
Debugger [candidate] (67.806 ms) : 0, 67806
Remote Config [baseline] (594.184 µs) : 0, 594
Remote Config [candidate] (587.33 µs) : 0, 587
Telemetry [baseline] (8.648 ms) : 0, 8648
Telemetry [candidate] (8.723 ms) : 0, 8723
Flare Poller [baseline] (3.734 ms) : 0, 3734
Flare Poller [candidate] (3.761 ms) : 0, 3761
ProfilingAgent [baseline] (98.22 ms) : 0, 98220
ProfilingAgent [candidate] (99.722 ms) : 0, 99722
Profiling [baseline] (98.816 ms) : 0, 98816
Profiling [candidate] (100.312 ms) : 0, 100312
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 3 performance regressions! Performance is the same for 17 metrics, 16 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.59.0-SNAPSHOT~28b6ab4d16, baseline=1.59.0-SNAPSHOT~7b4f50cd76
dateFormat X
axisFormat %s
section baseline
no_agent (1.183 ms) : 1171, 1195
. : milestone, 1183,
iast (3.186 ms) : 3139, 3232
. : milestone, 3186,
iast_FULL (5.963 ms) : 5902, 6023
. : milestone, 5963,
iast_GLOBAL (3.613 ms) : 3557, 3669
. : milestone, 3613,
profiling (2.073 ms) : 2055, 2092
. : milestone, 2073,
tracing (1.788 ms) : 1773, 1802
. : milestone, 1788,
section candidate
no_agent (1.19 ms) : 1178, 1201
. : milestone, 1190,
iast (3.266 ms) : 3221, 3311
. : milestone, 3266,
iast_FULL (5.867 ms) : 5808, 5926
. : milestone, 5867,
iast_GLOBAL (3.689 ms) : 3618, 3760
. : milestone, 3689,
profiling (2.058 ms) : 2039, 2078
. : milestone, 2058,
tracing (1.914 ms) : 1897, 1930
. : milestone, 1914,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.59.0-SNAPSHOT~28b6ab4d16, baseline=1.59.0-SNAPSHOT~7b4f50cd76
dateFormat X
axisFormat %s
section baseline
no_agent (17.778 ms) : 17599, 17958
. : milestone, 17778,
appsec (18.802 ms) : 18612, 18992
. : milestone, 18802,
code_origins (17.488 ms) : 17316, 17659
. : milestone, 17488,
iast (17.598 ms) : 17422, 17773
. : milestone, 17598,
profiling (18.584 ms) : 18399, 18768
. : milestone, 18584,
tracing (17.661 ms) : 17487, 17834
. : milestone, 17661,
section candidate
no_agent (18.265 ms) : 18078, 18452
. : milestone, 18265,
appsec (18.355 ms) : 18169, 18542
. : milestone, 18355,
code_origins (18.69 ms) : 18503, 18877
. : milestone, 18690,
iast (17.482 ms) : 17309, 17655
. : milestone, 17482,
profiling (18.68 ms) : 18495, 18865
. : milestone, 18680,
tracing (17.646 ms) : 17470, 17823
. : milestone, 17646,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.59.0-SNAPSHOT~28b6ab4d16, baseline=1.59.0-SNAPSHOT~7b4f50cd76
dateFormat X
axisFormat %s
section baseline
no_agent (1.476 ms) : 1464, 1487
. : milestone, 1476,
appsec (2.498 ms) : 2443, 2553
. : milestone, 2498,
iast (2.262 ms) : 2192, 2331
. : milestone, 2262,
iast_GLOBAL (2.305 ms) : 2235, 2374
. : milestone, 2305,
profiling (2.095 ms) : 2039, 2150
. : milestone, 2095,
tracing (2.076 ms) : 2022, 2130
. : milestone, 2076,
section candidate
no_agent (1.475 ms) : 1463, 1486
. : milestone, 1475,
appsec (2.494 ms) : 2439, 2549
. : milestone, 2494,
iast (2.256 ms) : 2187, 2325
. : milestone, 2256,
iast_GLOBAL (2.298 ms) : 2228, 2367
. : milestone, 2298,
profiling (2.086 ms) : 2031, 2141
. : milestone, 2086,
tracing (2.076 ms) : 2022, 2130
. : milestone, 2076,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.59.0-SNAPSHOT~28b6ab4d16, baseline=1.59.0-SNAPSHOT~7b4f50cd76
dateFormat X
axisFormat %s
section baseline
no_agent (15.529 s) : 15529000, 15529000
. : milestone, 15529000,
appsec (14.896 s) : 14896000, 14896000
. : milestone, 14896000,
iast (17.991 s) : 17991000, 17991000
. : milestone, 17991000,
iast_GLOBAL (18.142 s) : 18142000, 18142000
. : milestone, 18142000,
profiling (15.019 s) : 15019000, 15019000
. : milestone, 15019000,
tracing (14.573 s) : 14573000, 14573000
. : milestone, 14573000,
section candidate
no_agent (15.631 s) : 15631000, 15631000
. : milestone, 15631000,
appsec (15.275 s) : 15275000, 15275000
. : milestone, 15275000,
iast (17.933 s) : 17933000, 17933000
. : milestone, 17933000,
iast_GLOBAL (17.54 s) : 17540000, 17540000
. : milestone, 17540000,
profiling (15.139 s) : 15139000, 15139000
. : milestone, 15139000,
tracing (14.819 s) : 14819000, 14819000
. : milestone, 14819000,
|
Debugger benchmarksParameters
See matching parameters
SummaryFound 5 performance improvements and 0 performance regressions! Performance is the same for 4 metrics, 6 unstable metrics.
See unchanged results
Request duration reports for reportsgantt
title reports - request duration [CI 0.99] : candidate=None, baseline=None
dateFormat X
axisFormat %s
section baseline
noprobe (315.923 µs) : 293, 339
. : milestone, 316,
basic (278.359 µs) : 272, 285
. : milestone, 278,
loop (9.368 ms) : 9248, 9489
. : milestone, 9368,
section candidate
noprobe (321.081 µs) : 283, 359
. : milestone, 321,
basic (278.139 µs) : 272, 285
. : milestone, 278,
loop (8.962 ms) : 8956, 8967
. : milestone, 8962,
|
|
Hi! 👋 Thanks for your pull request! 🎉 To help us review it, please make sure to:
If you need help, please check our contributing guidelines. |
|
commit unverified reopened as #10505 |
What Does This Do
In Lambda, the inner stack trace is truncated -- stack frames from
fileName='AWSLambda.java'are removed. Therefore, in the original code, we would end up with a negativecurrentIdx, resulting in an error occurring insanityCheckSnapshotAssignment. This PR adds a fallback to fix the mismatched pointer.Motivation
Reopens #8849
SVLS-6855
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]