Skip to content

Enable enhanced metrics by default and write enhanced metrics to logs #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
swfunc merged 5 commits into from
Feb 4, 2020
Merged

Enable enhanced metrics by default and write enhanced metrics to logs #43

swfunc merged 5 commits into from
Feb 4, 2020

Conversation

@swfunc
Copy link
Contributor

@swfunc swfunc commented Feb 3, 2020

What does this PR do?

  • Defaults the DD_ENHANCED_METRICS option to true
  • If DD_ENHANCED_METRICS is enabled, always writes enhanced metrics to stdout

Motivation

Bringing enhanced metrics out of beta

Testing Guidelines

Tested with demo functions, updated unit tests

@swfunc swfunc requested a review from a team as a code owner February 3, 2020 21:02
tianchu
tianchu approved these changes Feb 4, 2020
View reviewed changes
Copy link
Collaborator

@tianchu tianchu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@swfunc swfunc merged commit 3e676f4 into master Feb 4, 2020
@swfunc swfunc mentioned this pull request Feb 5, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tianchu tianchu tianchu approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@swfunc @tianchu