Skip to content

Modify end time of lambda load span to be last cold start node's end_time #319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
joeyzhao2018 merged 5 commits into from
Apr 12, 2023
Merged

Modify end time of lambda load span to be last cold start node's end_time #319

joeyzhao2018 merged 5 commits into from
Apr 12, 2023

Conversation

@joeyzhao2018
Copy link
Contributor

@joeyzhao2018 joeyzhao2018 commented Apr 10, 2023 •
edited
Loading

What does this PR do?

  1. Modify end time of lambda load span to be last cold start node's end_time corresponding nodejs layer PR
  2. Also ignore AttributeError when checking whether is_authorizer_response

Motivation

Testing Guidelines

Additional Notes

Types of Changes

  • Bug fix
  • New feature
  • Breaking change
  • Misc (docs, refactoring, dependency upgrade, etc.)

Check all that apply

  • This PR's description is comprehensive
  • This PR contains breaking changes that are documented in the description
  • This PR introduces new APIs or parameters that are documented and unlikely to change in the foreseeable future
  • This PR impacts documentation, and it has been updated (or a ticket has been logged)
  • This PR's changes are covered by the automated tests
  • This PR collects user input/sensitive content into Datadog
  • This PR passes the integration tests (ask a Datadog member to run the tests)

@joeyzhao2018 joeyzhao2018 requested a review from a team as a code owner April 10, 2023 19:26
@joeyzhao2018 joeyzhao2018 force-pushed the joey/end_time_adjust branch from 32b4a75 to 6fecf7c Compare April 10, 2023 22:24
@joeyzhao2018 joeyzhao2018 force-pushed the joey/end_time_adjust branch from 6fecf7c to 96354c6 Compare April 12, 2023 15:38
@joeyzhao2018 joeyzhao2018 merged commit 12b2c8b into main Apr 12, 2023
@joeyzhao2018 joeyzhao2018 deleted the joey/end_time_adjust branch April 12, 2023 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@astuyve astuyve astuyve approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@joeyzhao2018 @astuyve