Fix audio_buffer leak

jdelStrother · chrisn · commit 89aaf27f92ac · 2020-08-26T11:56:38.000+01:00
Keeping these event listeners around meant that the
ArrayBuffer 'audio_buffer' was never cleaned up
diff --git a/lib/builders/audiodecoder.js b/lib/builders/audiodecoder.js
@@ -20,7 +20,7 @@ function processWorker(workerArgs, callback) {
       return data_length;
     }
 
-    this.addEventListener("message", function(evt) {
+    this.addEventListener("message", function listener(evt) {
       var scale = evt.data.scale;
       var amplitude_scale = evt.data.amplitude_scale;
       var split_channels = evt.data.split_channels;
@@ -126,10 +126,14 @@ function processWorker(workerArgs, callback) {
       }
 
       this.postMessage(data_object);
+      this.removeEventListener("message", listener);
     });
   });
-  worker.addEventListener("message", function(evt) {
+  worker.addEventListener("message", function listener(evt) {
     callback(evt.data);
+    // We're only sending a single message to each listener, so
+    // remove the callback afterwards to avoid leaks.
+    worker.removeEventListener("message", listener);
   });
   worker.postMessage(workerArgs);
 }
