Javascipt IV #1
Open
Javascipt IV #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LaikaFusion
approved these changes
Apr 28, 2019
Collaborator
LaikaFusion
left a comment
LaikaFusion
left a comment
There was a problem hiding this comment.
You're getting a bit lazy with the pull requests, gotta do them more frequently.
Your listSubjects method may not be the best. You don't really want to just drop an array in there
Beyond that everything looks great. I can see you're using prettier, because your code is well formatted
PS thanks for the shoutout
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.