Initial implementation of dave negotiation handling. #2367
Conversation
…lar constructors.
…oice callbacks. Cleaned up VoiceStateFactory
… payloads and other user ssrc parsing.
Plerx2493
left a comment
Plerx2493
left a comment
There was a problem hiding this comment.
I have only looked at it from a codestyle perspective because im not yet familiar with DAVE/MLS etc. Its mostly nitpicks i guess
…lect protocol. Changed some variable names to be more clear.
There was a problem hiding this comment.
generally looks good, but i question whether we need all those payload types there considering they're all the same structure + an interior Data field. could we just have an InboundVoicePayload and OutboundVoicePayload with an object Data (and subsequently reuse the already-existing payload objects in the Protocol folder, perhaps, or remove those in this PR)
yeah, honestly it was just easier to create those types by just converting the json. Ideally a DiscordMessage[TPayload] would be better |
|
try to avoid confusion with |
akiraveliara
left a comment
akiraveliara
left a comment
There was a problem hiding this comment.
ideally, xmldocs should be complete and correct sentences, and xmldoc blocks should have a newline above them, but i can also take care of these at a later point
3 participants
Make sure you familiarize yourself with our contributing guidelines.
Summary
Fixes #issue/Resolves #issue/Implements functionality. Short description of changes.
Details
You can put detailed description of the changes in here.
Changes proposed
Notes
Any additional notes go here.