Create an analyzer for DSharpPlus #2154
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also renamed everything from DSharpPlus.Analyzer to DSharpPlus.Analyzers
…late/analyzer # Conflicts: # DSharpPlus.sln
Checks so the user uses pagination related methods instead of single entity fetching
… commands that specify guilds to install too
# Conflicts: # DSharpPlus.sln # Directory.Packages.props
akiraveliara
reviewed
Nov 6, 2024
DSharpPlus.Analyzers/DSharpPlus.Analyzers/Commands/ProcessorCheckAnalyzer.cs
Outdated
Show resolved
Hide resolved
DSharpPlus.Analyzers/DSharpPlus.Analyzers/Core/HasPermissionAnalyzer.cs
Outdated
Show resolved
Hide resolved
DSharpPlus.Analyzers/DSharpPlus.Analyzers/Core/SingleEntityGetRequestAnalyzer.cs
Show resolved
Hide resolved
Instellate
commented
Nov 6, 2024
Also made more tests for SingleEntityGetRequestAnalyzer
# Conflicts: # DSharpPlus/DSharpPlus.csproj # Directory.Packages.props
Also cleaned up some small documentation inconsistency
akiraveliara
requested changes
Feb 20, 2025
Member
akiraveliara
left a comment
akiraveliara
left a comment
There was a problem hiding this comment.
it appears that you're fundamentally misunderstanding how permissions work. everything else looks... fine? i don't understand the recent severity changes, though
DSharpPlus.Analyzers/DSharpPlus.Analyzers.Test/UseDiscordPermissionsTest.cs
Outdated
Show resolved
Hide resolved
DSharpPlus.Analyzers/DSharpPlus.Analyzers.Test/HasPermissionTest.cs
Outdated
Show resolved
Hide resolved
DSharpPlus.Analyzers/DSharpPlus.Analyzers.Test/UseDiscordPermissionsTest.cs
Outdated
Show resolved
Hide resolved
DSharpPlus.Analyzers/DSharpPlus.Analyzers/Core/UseDiscordPermissionsAnalyzer.cs
Outdated
Show resolved
Hide resolved
Incremented all core IDs by one as new obsolete IDs have been added
Member
Author
|
There is one more change needed to be done and that is to package the analyzer dll into the Found this article that guides on how to do that. So I will use that as an example and implement it later this evening (CET). |
akiraveliara
reviewed
Mar 4, 2025
blehh
# Conflicts: # DSharpPlus.sln # Directory.Packages.props
This is untested
Limited triggers for DSP0010 to only some numerical operations.
akiraveliara
approved these changes
May 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Make an analyzer for DSharpPlus that tells the user various wrong usage of the library. Related to #2096
Notes
I do not know if this is too barebones to be merged yet. If it is good enough I will convert it from a draft to a pull request.
How documentation needs to be done is also a discussion that is needed to be done.
There's also typos and stuff so if anyone have time preferably commit it to the branch, otherwise leave it as a review.