support webhook events #2145
Merged
support webhook events #2145
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akiraveliara
commented
Oct 30, 2024
OoLunar
approved these changes
Nov 3, 2024
Contributor
OoLunar
left a comment
OoLunar
left a comment
There was a problem hiding this comment.
A very vague LGTM as I'm not familiar with ASP.NET
DSharpPlus/Net/InboundWebhooks/DiscordApplicationAuthorizedEvent.cs
Outdated
Show resolved
Hide resolved
…pplus/dsharpplus into velvet/feat/webhook-events
Plerx2493
approved these changes
Nov 16, 2024
Member
Plerx2493
left a comment
Plerx2493
left a comment
There was a problem hiding this comment.
RTM as far as im concernd. Can we mark the "old" http interaction nuget package as obsolete and point at the "new" one? I renamed it so it will be a new package afaik
Member
Author
|
yeah, we can |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds support for webhook events, including a default adapter for ASP.NET.
the internal setup for this is always functional, and developing adapters for other HTTP should be trivial. furthermore, HTTP interactions have been consolidated into near-identical handling to further simplify internal and external implementation of this feature.