retry if registering commands fails with a server error exception #2032
Conversation
akiraveliara
added
enhancement
commands
|
Closes #1986 |
Im not sure if i would say this closes the issue. Yes it helps because we retry it when it fails but i think we should also add something like IRestRequest.HasLongTimeout which drasticly increase the timeout for this request (maybe 10 minutes?). This would lead to better registration and other reqeusts wont have a long timeout |
You are right, in more ways than 1. However, I believe the timeout's in question will be resolved by some REST improvements and is part of a larger issue, which is already planned and tracked for v5 in #1580 |
| IEnumerable<DiscordApplicationCommand> commands | ||
| ) | ||
| { | ||
| while (true) |
There was a problem hiding this comment.
i think we should still have some kind of max retries, maybe 5 or 10
There was a problem hiding this comment.
maybe, probably via config
There was a problem hiding this comment.
not sure if this has been fixed yet but I'd reiterate what plerx said, it's important to not keep retrying indefinitely. Especially if the issue ends up being an us issue. We can not just assume our request is "correct". Especially since this is Discord we're talking about.
Im not sure about that, afaik the underlying issue is that the registration endpoint can have a very fluctuating time usage, which is something we will have to special case |
|
can we confirm this with Discord somehow? |
Its not documented by discord, maybe we should open an issue on discords repo |
|
maybe. if so, we shouldn't merge this until we have confirmation that this is a workable approach in the face of discord tomfoolery |
The issue opened by @ecrocombe was closed as not able to reproduce. Im not sure how to tackle this. |
|
superseded by efforts in #2115 |
4 participants
this is a bit dubious because it can cause long hangs in the extension, would appreciate any potential ideas