Rework command filtering for processor specific commands #1914
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DSharpPlus.Commands/Processors/BaseCommandProcessor/BaseCommandProcessor.cs
Outdated
Show resolved
Hide resolved
akiraveliara
approved these changes
May 24, 2024
Member
|
for posterity, i'll also link this here: https://canary.discord.com/channels/379378609942560770/379386901725052928/1243623796712149082 |
akiraveliara
approved these changes
May 26, 2024
DSharpPlus.Tests/Commands/CommandFiltering/TestMultiLevelSubCommandsFiltered.cs
Show resolved
Hide resolved
DSharpPlus.Tests/Commands/CommandFiltering/TestMultiLevelSubCommandsFiltered.cs
Outdated
Show resolved
Hide resolved
Member
|
does this also fix #1782 ? |
Member
Author
Don't think so, will take a look later |
Plerx2493
force-pushed
the
plerx/enhancement/CommandProcessorFilter
branch
from
7853eec to
fc5f56e
Compare
akiraveliara
approved these changes
Jun 3, 2024
…sorFilter # Conflicts: # DSharpPlus.Commands/Processors/SlashCommands/SlashCommandProcessor.cs
OoLunar
pushed a commit
that referenced
this pull request
Oct 3, 2024
* Rework command filtering for processor specific commands * formatting * Compute ContextType from BaseCommandProcessor generic parameter * using neat with syntax * Add tests * Fix test command class * Make DSP.C internal open to other packages * Internals only open to DPS.Tests * Fix context menu processors and add tests for those * Restructur command processors to allow better testing * fix misclick and rework SlashCommandProcessor to allow better testing * Better naming in SlashCommandProcessor * finish docs * Update tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Looks at AllowedProcessor attributes and the commandcontext type used in the command method