Skip to content

Nuke DiscordConfiguration#UseRelativeRatelimits #1764

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
akiraveliara merged 1 commit into from
Feb 13, 2024
Merged

Nuke DiscordConfiguration#UseRelativeRatelimits #1764

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion DSharpPlus/Clients/DiscordWebhookClient.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ public DiscordWebhookClient()
/// <param name="loggerFactory">The optional logging factory to use for this client.</param>
/// <param name="minimumLogLevel">The minimum logging level for messages.</param>
/// <param name="logTimestampFormat">The timestamp format to use for the logger.</param>
public DiscordWebhookClient(IWebProxy proxy = null, TimeSpan? timeout = null, bool useRelativeRateLimit = true,
public DiscordWebhookClient(IWebProxy proxy = null, TimeSpan? timeout = null,
ILoggerFactory loggerFactory = null, LogLevel minimumLogLevel = LogLevel.Information, string logTimestampFormat = "yyyy-MM-dd HH:mm:ss zzz")
{
this._minimumLogLevel = minimumLogLevel;
Expand Down
9 changes: 0 additions & 9 deletions DSharpPlus/DiscordConfiguration.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,14 +42,6 @@ public string Token
/// </summary>
public LogLevel MinimumLogLevel { internal get; set; } = LogLevel.Information;

/// <summary>
/// <para>Sets whether to rely on Discord for NTP (Network Time Protocol) synchronization with the "X-Ratelimit-Reset-After" header.</para>
/// <para>If the system clock is not synced, setting this to true will ensure ratelimits are synced with Discord and reduce the risk of hitting one.</para>
/// <para>This should only be set to false if the system clock is synced with NTP.</para>
/// <para>Defaults to true.</para>
/// </summary>
public bool UseRelativeRatelimit { internal get; set; } = true;

/// <summary>
/// <para>Allows you to overwrite the time format used by the internal debug logger.</para>
/// <para>Only applicable when <see cref="LoggerFactory"/> is set left at default value. Defaults to ISO 8601-like format.</para>
Expand Down Expand Up @@ -194,7 +186,6 @@ public DiscordConfiguration(DiscordConfiguration other)
this.Token = other.Token;
this.TokenType = other.TokenType;
this.MinimumLogLevel = other.MinimumLogLevel;
this.UseRelativeRatelimit = other.UseRelativeRatelimit;
this.LogTimestampFormat = other.LogTimestampFormat;
this.LargeThreshold = other.LargeThreshold;
this.AutoReconnect = other.AutoReconnect;
Expand Down