Skip to content

Conversation

@VelvetToroyashi
Copy link
Member

Fixes an oversight in #1680; see commit body for detials

This commit fixes a bug with slash commands wherein a command with a dash in its name (and by extension, a space) would end up being translated to snake_case, but doing a lookup of the command to then map to an ID would always fail, as the names did not match.
Copy link
Contributor

@OoLunar OoLunar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@OoLunar OoLunar merged commit d3dbddb into DSharpPlus:master Jan 31, 2024
@OoLunar OoLunar self-assigned this Jan 31, 2024
@OoLunar OoLunar added bugfix enhancement commands For issues related to DSharpPlus.Commands labels Jan 31, 2024
OoLunar pushed a commit that referenced this pull request Oct 3, 2024
This commit fixes a bug with slash commands wherein a command with a dash in its name (and by extension, a space) would end up being translated to snake_case, but doing a lookup of the command to then map to an ID would always fail, as the names did not match.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix commands For issues related to DSharpPlus.Commands enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants