Cache rework #1647
Closed
Cache rework #1647
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inftord
approved these changes
Oct 10, 2023
Member
inftord
left a comment
inftord
left a comment
There was a problem hiding this comment.
overall LGTM, just a one nitpick regarding docs
Member
VelvetToroyashi
left a comment
VelvetToroyashi
left a comment
There was a problem hiding this comment.
Looks OK at a cursory glance, waiting for Livia for additional input.
Member
akiraveliara
left a comment
akiraveliara
left a comment
There was a problem hiding this comment.
preliminarily looks good, but we'll have to see how it turns out in the end. left a question.
inftord
reviewed
Oct 31, 2023
# Conflicts: # DSharpPlus/Entities/AuditLogs/AuditLogParser.cs # DSharpPlus/Entities/AuditLogs/DiscordAuditLogEntry.cs # DSharpPlus/Entities/AuditLogs/Entries/DiscordAuditLogAutoModerationExecutedEntry.cs # DSharpPlus/Entities/AuditLogs/Entries/DiscordAuditLogAutoModerationRuleEntry.cs # DSharpPlus/Entities/AuditLogs/Entries/DiscordAuditLogBanEntry.cs # DSharpPlus/Entities/AuditLogs/Entries/DiscordAuditLogBotAddEntry.cs # DSharpPlus/Entities/AuditLogs/Entries/DiscordAuditLogChannelEntry.cs # DSharpPlus/Entities/AuditLogs/Entries/DiscordAuditLogEmojiEntry.cs # DSharpPlus/Entities/AuditLogs/Entries/DiscordAuditLogGuildEntry.cs # DSharpPlus/Entities/AuditLogs/Entries/DiscordAuditLogGuildScheduledEventEntry.cs # DSharpPlus/Entities/AuditLogs/Entries/DiscordAuditLogKickEntry.cs # DSharpPlus/Entities/AuditLogs/Entries/DiscordAuditLogMemberMoveEntry.cs # DSharpPlus/Entities/AuditLogs/Entries/DiscordAuditLogMemberUpdateEntry.cs # DSharpPlus/Entities/AuditLogs/Entries/DiscordAuditLogMessageEntry.cs # DSharpPlus/Entities/AuditLogs/Entries/DiscordAuditLogMessagePinEntry.cs # DSharpPlus/Entities/AuditLogs/Entries/DiscordAuditLogOverwriteEntry.cs # DSharpPlus/Entities/AuditLogs/Entries/DiscordAuditLogRoleUpdateEntry.cs # DSharpPlus/Entities/AuditLogs/Entries/DiscordAuditLogStickerEntry.cs # DSharpPlus/Entities/AuditLogs/Entries/DiscordAuditLogThreadEventEntry.cs # DSharpPlus/Entities/AuditLogs/Entries/DiscordAuditLogWebhookEntry.cs # DSharpPlus/Entities/AuditLogs/PropertyChange.cs # DSharpPlus/Entities/Guild/DiscordGuild.cs # DSharpPlus/Entities/Guild/ScheduledEvents/DiscordScheduledGuildEvent.cs # DSharpPlus/Net/Rest/DiscordApiClient.cs
# Conflicts: # DSharpPlus/Clients/BaseDiscordClient.cs # DSharpPlus/Clients/DiscordClient.cs # DSharpPlus/Entities/AuditLogs/AuditLogActionCategory.cs # DSharpPlus/Entities/AuditLogs/AuditLogActionType.cs # DSharpPlus/Entities/AuditLogs/DiscordAuditLogEntry.cs # DSharpPlus/Entities/AuditLogs/Entries/DiscordAuditLogApplicationCommandPermissionEntry.cs # DSharpPlus/Entities/AuditLogs/Entries/DiscordAuditLogAutoModerationExecutedEntry.cs # DSharpPlus/Entities/AuditLogs/Entries/DiscordAuditLogAutoModerationRuleEntry.cs # DSharpPlus/Entities/AuditLogs/Entries/DiscordAuditLogBanEntry.cs # DSharpPlus/Entities/AuditLogs/Entries/DiscordAuditLogBotAddEntry.cs # DSharpPlus/Entities/AuditLogs/Entries/DiscordAuditLogChannelEntry.cs # DSharpPlus/Entities/AuditLogs/Entries/DiscordAuditLogEmojiEntry.cs # DSharpPlus/Entities/AuditLogs/Entries/DiscordAuditLogGuildEntry.cs # DSharpPlus/Entities/AuditLogs/Entries/DiscordAuditLogGuildScheduledEventEntry.cs # DSharpPlus/Entities/AuditLogs/Entries/DiscordAuditLogIntegrationEntry.cs # DSharpPlus/Entities/AuditLogs/Entries/DiscordAuditLogInviteEntry.cs # DSharpPlus/Entities/AuditLogs/Entries/DiscordAuditLogKickEntry.cs # DSharpPlus/Entities/AuditLogs/Entries/DiscordAuditLogMemberDisconnectEntry.cs # DSharpPlus/Entities/AuditLogs/Entries/DiscordAuditLogMemberMoveEntry.cs # DSharpPlus/Entities/AuditLogs/Entries/DiscordAuditLogMemberUpdateEntry.cs # DSharpPlus/Entities/AuditLogs/Entries/DiscordAuditLogMessageEntry.cs # DSharpPlus/Entities/AuditLogs/Entries/DiscordAuditLogMessagePinEntry.cs # DSharpPlus/Entities/AuditLogs/Entries/DiscordAuditLogOverwriteEntry.cs # DSharpPlus/Entities/AuditLogs/Entries/DiscordAuditLogPruneEntry.cs # DSharpPlus/Entities/AuditLogs/Entries/DiscordAuditLogStickerEntry.cs # DSharpPlus/Entities/AuditLogs/Entries/DiscordAuditLogThreadEventEntry.cs # DSharpPlus/Entities/AuditLogs/Entries/DiscordAuditLogWebhookEntry.cs # DSharpPlus/Entities/AuditLogs/PropertyChange.cs # DSharpPlus/Entities/Channel/DiscordChannel.cs # DSharpPlus/Entities/Channel/Message/DiscordMessage.cs # DSharpPlus/Entities/Channel/Message/DiscordMessageReference.cs # DSharpPlus/Entities/Channel/Message/DiscordMessageSticker.cs # DSharpPlus/Entities/Voice/DiscordVoiceState.cs # DSharpPlus/IMessageCacheProvider.cs # DSharpPlus/Net/Rest/DiscordApiClient.cs # tools/AutoUpdateChannelDescription/Program.cs
Member
Author
|
Closing in favor of the gateway rewrite. branch was moved to plerx/backlog/cache-rewrite |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add the concept of a centralized cache and provide the possibilty for users to implement their own caching provider. I also have, due to the nature of dispatch event based caching, overhauled DiscordClient.Dispatch to fix some bugs and make it more readable
Tasks
Testing
Note
This PR brings massive breaking changes to both entity representations and eventArgs so they reflect more accurately what entities are cached and also to provide IDs for all fields which are cached entities. The user then can request those entities if necessary