Cleanup DSharpPlus.Rest #1548
Cleanup DSharpPlus.Rest #1548
Conversation
inftord
left a comment
inftord
left a comment
There was a problem hiding this comment.
one small nitpick, but overall it's good
akiraveliara
left a comment
akiraveliara
left a comment
There was a problem hiding this comment.
the formatting is very inconsistent, both with itself and with allman style. i've left comments on the most egregious violations i've caught, but i implore you to take a look over all of it - there's a fair few more.
i've also left a nitpick or two but those aren't super important
| DefaultReaction? defaultReactionEmoji = null, | ||
| IEnumerable<DiscordForumTagBuilder>? availableTags = null, | ||
| DefaultSortOrder? defaultSortOrder = null | ||
| ) => type switch |
There was a problem hiding this comment.
please put this in its own block, not an expression body
There was a problem hiding this comment.
The .editorconfig will cause a compiler warning, informing us to make it an expression. What is your proposed solution?
There was a problem hiding this comment.
change it to only prefer expressions on single lines?
| Optional<int> defaultPerUserRatelimit, | ||
| Optional<DefaultSortOrder?> defaultSortOrder, | ||
| Optional<DefaultForumLayout> defaultForumLayout | ||
| ) => ApiClient.ModifyChannelAsync |
| VerificationLevel? verificationLevel, | ||
| DefaultMessageNotifications? defaultMessageNotifications, | ||
| SystemChannelFlags? systemChannelFlags | ||
| ) => ApiClient.CreateGuildAsync(name, regionId, iconBase64, verificationLevel, defaultMessageNotifications, systemChannelFlags); |
| Optional<ulong?> rulesChannelId, | ||
| Optional<SystemChannelFlags> systemChannelFlags, | ||
| string reason | ||
| ) => ApiClient.ModifyGuildAsync( |
| IEnumerable<DiscordRole> roles, | ||
| bool muted, | ||
| bool deafened | ||
| ) => ApiClient.AddGuildMemberAsync(guildId, userId, accessToken, nick, roles, muted, deafened); |
| Optional<ulong?> voiceChannelId, | ||
| Optional<DateTimeOffset?> communicationDisabledUntil, | ||
| string reason | ||
| ) => ApiClient.ModifyGuildMemberAsync(guildId, userId, nick, roleIds, mute, deaf, voiceChannelId, communicationDisabledUntil, reason); |
| string reason, | ||
| Stream icon, | ||
| DiscordEmoji emoji | ||
| ) => ApiClient.ModifyGuildRoleAsync |
|
I think this is superseded by #1624 ? |
|
no, but it would at least need to be modified for #1624 |
|
Closing as it's blocked by #1647. When that PR merges, I will attempt this PR once more. |
4 participants
Summary
Splits the
DSharpPlus.Restproject into multiple files, cleaning up code and adding some documentation.Notes
Per usual, entirely untested. Requesting @inftord's review for incorrect/missing docs or parameters.