Skip to content

Improving SlashCommandsExtension #1474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
OoLunar merged 2 commits into from
Feb 28, 2023
Merged

Improving SlashCommandsExtension #1474

OoLunar merged 2 commits into from
Feb 28, 2023

Conversation

@Plerx2493
Copy link
Member

@Plerx2493 Plerx2493 commented Feb 22, 2023

##Summary
Adding additional context in exceptions thrown when registering command methods. Also add the return type check from #1472 to sub methods for command groups

Moved Pr #1473 to right branch

@Plerx2493
Copy link
Member Author

Plerx2493 commented Feb 23, 2023

I would like to also add additonal information in exceptions thrown from ParseParameter but it only gets the parameters not the MethodInfo. Maybe we could change it to methodinfo and strip the context parameter in there and dont do it before each invokation?
@OoLunar what are your thoughts?

@OoLunar
Copy link
Contributor

OoLunar commented Feb 23, 2023

@OoLunar what are your thoughts?

Head empty

@Plerx2493
Copy link
Member Author

Plerx2493 commented Feb 26, 2023

I would like to also add additonal information in exceptions thrown from ParseParameter but it only gets the parameters not the MethodInfo. Maybe we could change it to methodinfo and strip the context parameter in there and dont do it before each invokation? @OoLunar what are your thoughts?

ok, next time i should check which branch i checked out. in this branch its already pointed out which method is throwing the exception.

Should be ready to merge

@Plerx2493 Plerx2493 marked this pull request as ready for review February 26, 2023 22:25
@OoLunar
Copy link
Contributor

OoLunar commented Feb 28, 2023

LGTM, thanks for contributing o7

@OoLunar OoLunar merged commit d7b2caf into DSharpPlus:fix/v4/slashies-cleanup Feb 28, 2023
@Plerx2493 Plerx2493 deleted the fix/v4/slashies-cleanup branch February 28, 2023 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Plerx2493 @OoLunar