Improving SlashCommandsExtension #1473
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
I also want to add more informations to the exceptions in the parseParameters function but this would require to change the parameters of this method Function: |
Contributor
|
Perhaps these changes should be pushed to the fix/v4/slashies-cleanup branch? |
Member
Author
|
Oh i forgot you do a revamp. Can i move it some how, can you do it or do i have to make a new PR? |
Contributor
|
You could do a rebase: |
Contributor
|
Oh, you'll have to make a new PR |
Member
Author
|
New PR is open |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adding additional context in exceptions thrown when registering command methods. Also add the return type check from #1472 to sub methods for command groups