Skip to content

Cache threads upon thread creation #1366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
OoLunar merged 1 commit into from
Aug 5, 2022
Merged

Cache threads upon thread creation #1366

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions DSharpPlus/Entities/Channel/DiscordChannel.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -273,7 +273,7 @@ public Task<DiscordMessage> SendMessageAsync(DiscordEmbed embed)
if (!Utilities.IsTextableChannel(this))
throw new ArgumentException($"{this.Type} channels do not support sending text messages.");

return this.Discord.ApiClient.CreateMessageAsync(this.Id, null, embed != null ? new[] { embed } : null, replyMessageId: null, mentionReply: false, failOnInvalidReply: false);
return this.Discord.ApiClient.CreateMessageAsync(this.Id, null, embed != null ? new[] { embed } : null, replyMessageId: null, mentionReply: false, failOnInvalidReply: false);
}

/// <summary>
Expand Down Expand Up @@ -1015,14 +1015,16 @@ public override string ToString()
/// <exception cref="NotFoundException">Thrown when the channel or message does not exist.</exception>
/// <exception cref="BadRequestException">Thrown when an invalid parameter was provided.</exception>
/// <exception cref="ServerErrorException">Thrown when Discord is unable to process the request.</exception>
public Task<DiscordThreadChannel> CreateThreadAsync(DiscordMessage message, string name, AutoArchiveDuration archiveAfter, string reason = null)
public async Task<DiscordThreadChannel> CreateThreadAsync(DiscordMessage message, string name, AutoArchiveDuration archiveAfter, string reason = null)
{
if (this.Type != ChannelType.Text && this.Type != ChannelType.News)
throw new ArgumentException("Threads can only be created within text or news channels.");
else if (message.ChannelId != this.Id)
throw new ArgumentException("You must use a message from this channel to create a thread.");

return this.Discord.ApiClient.CreateThreadFromMessageAsync(this.Id, message.Id, name, archiveAfter, reason);
var threadChannel = await this.Discord.ApiClient.CreateThreadFromMessageAsync(this.Id, message.Id, name, archiveAfter, reason);
this.Guild._threads.AddOrUpdate(threadChannel.Id, threadChannel, (key, old) => threadChannel);
return threadChannel;
}

/// <summary>
Expand All @@ -1036,7 +1038,7 @@ public Task<DiscordThreadChannel> CreateThreadAsync(DiscordMessage message, stri
/// <exception cref="NotFoundException">Thrown when the channel or message does not exist.</exception>
/// <exception cref="BadRequestException">Thrown when an invalid parameter was provided.</exception>
/// <exception cref="ServerErrorException">Thrown when Discord is unable to process the request.</exception>
public Task<DiscordThreadChannel> CreateThreadAsync(string name, AutoArchiveDuration archiveAfter, ChannelType threadType, string reason = null)
public async Task<DiscordThreadChannel> CreateThreadAsync(string name, AutoArchiveDuration archiveAfter, ChannelType threadType, string reason = null)
{
if (this.Type != ChannelType.Text && this.Type != ChannelType.News)
throw new InvalidOperationException("Threads can only be created within text or news channels.");
Expand All @@ -1047,7 +1049,9 @@ public Task<DiscordThreadChannel> CreateThreadAsync(string name, AutoArchiveDura
else if (threadType == ChannelType.PrivateThread && !this.Guild.Features.Contains("PRIVATE_THREADS"))
throw new ArgumentException("This guild cannot create private threads.");

return this.Discord.ApiClient.CreateThreadAsync(this.Id, name, archiveAfter, threadType, reason);
var threadChannel = await this.Discord.ApiClient.CreateThreadAsync(this.Id, name, archiveAfter, threadType, reason);
this.Guild._threads.AddOrUpdate(threadChannel.Id, threadChannel, (key, old) => threadChannel);
return threadChannel;
}

#endregion
Expand Down