Skip to content

Fix memberBefore missing roles in GuildMemberUpdateEventArgs when not… #1364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
OoLunar merged 3 commits into from
Aug 9, 2022
Merged

Fix memberBefore missing roles in GuildMemberUpdateEventArgs when not… #1364

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3909ddb
Fix memberBefore missing roles in GuildMemberUpdateEventArgs when not…
selfdocumentingcode Aug 2, 2022
df84223
Update cached guild member in OnGuildMemberUpdateEventAsync internal …
selfdocumentingcode Aug 2, 2022
1c46b18
Update DiscordClient.Dispatch.cs
OoLunar Aug 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions DSharpPlus/Clients/DiscordClient.Dispatch.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1240,12 +1240,14 @@ internal async Task OnGuildMemberRemoveEventAsync(TransportUser user, DiscordGui
internal async Task OnGuildMemberUpdateEventAsync(TransportMember member, DiscordGuild guild)
{
var userAfter = new DiscordUser(member.User) { Discord = this };
userAfter = this.UpdateUserCache(userAfter);
_ = this.UpdateUserCache(userAfter);

var memberAfter = new DiscordMember(member) { Discord = this, _guild_id = guild.Id };

if (!guild.Members.TryGetValue(member.User.Id, out var memberBefore))
memberBefore = new DiscordMember(userAfter) { Discord = this, _guild_id = guild.Id };
memberBefore = new DiscordMember(member) { Discord = this, _guild_id = guild.Id };

guild._members.AddOrUpdate(member.User.Id, memberAfter, (_, _) => memberAfter);

var ea = new GuildMemberUpdateEventArgs
{
Expand Down