Refactored the OracleValueConverter to support Get<int> and Get<long>. #44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Havagan
commented
Jul 31, 2020
Havagan
commented
- Fixes Conversion exception thrown for OracleDynamicParameters.Get<int>() on an output parameter with a NUMBER (OracleDecimal) db type. #40
- Fixes List of defined Parameters in OracleDynamicParameters cannot be read before execution #42
- Refactored the OracleValueConverter to handle OracleParameter values and allow Oracle native NUMBER values to convert to Int32 and Int64.
- Refactored the OracleValueConverter.GetParameter() method to return OracleParameterInfo instead of the AttachedParam.
- Removed .NET 4.5.1 framework support (EOL).
- Updated Dapper version to 2.0.35.
…and allow Oracle native NUMBER values to convert to Int32 and Int64. Removed .NET 4.5.1 framework support. Updated Dapper version to 2.0.35.
…the AttachedParam.
Contributor
Author
|
Sorry for all the closed pull requests. Just learning git/github and working with other repos. |
epaulsen
suggested changes
Aug 3, 2020
Contributor
epaulsen
left a comment
epaulsen
left a comment
There was a problem hiding this comment.
Great PR, thanks. Thumbs up for adding more tests.
If you can add a net461 TFM(see comments) so that we don't break anything for .net framework 4.6.x users we should be able to merge this and ship a new version shortly.
epaulsen
approved these changes
Aug 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.