Skip to content

Ability to read and log parameters before execution #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
epaulsen merged 1 commit into from
May 8, 2020
Merged

Ability to read and log parameters before execution #37

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion src/Dapper.Oracle/OracleDynamicParameters.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,18 @@ public IEnumerable<string> ParameterNames
/// <returns>The value, note DBNull.Value is not returned, instead the value is returned as null</returns>
public T Get<T>(string name)
{
var val = Parameters[Clean(name)].AttachedParam.Value;
var paramInfo = Parameters[Clean(name)];
var attachedParam = paramInfo.AttachedParam;
object val = attachedParam == null ? paramInfo.Value : attachedParam.Value;
if (val == DBNull.Value)
{
if (default(T) != null)
{
throw new ApplicationException("Attempting to cast a DBNull to a non nullable type! Note that out/return parameters will not have updated values until the data stream completes (after the 'foreach' for Query(..., buffered: false), or after the GridReader has been disposed for QueryMultiple)");
}
return default(T);
}

return OracleValueConverter.Convert<T>(val);
}

Expand Down
8 changes: 8 additions & 0 deletions src/Tests.Dapper.Oracle/OracleDynamicParameterTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,5 +152,13 @@ public void GetParameter_DoesNotReturnNull(IDbCommand cmd)
param.Value.Should().Be("Bar");
param.ArrayBindSize.Should().BeSameAs(bindSizeArray);
}

[Fact]
public void GetParameterValue()
{
testObject.Add("Foo", "Bar", OracleMappingType.Varchar2);

testObject.Get<string>("Foo").Should().Be("Bar");
}
}
}