[IDEA] feat!: discriminate every BomRef as promissed#861
Draft
jkowalleck wants to merge 1 commit intomainfrom
Draft
[IDEA] feat!: discriminate every BomRef as promissed#861jkowalleck wants to merge 1 commit intomainfrom
jkowalleck wants to merge 1 commit intomainfrom
Conversation
jkowalleck
changed the title
jkowalleck
force-pushed
the
feat/discriminate_all_bomrefs
branch
from
313c279 to
b58abc7
Compare
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferences |
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
jkowalleck
force-pushed
the
feat/discriminate_all_bomrefs
branch
from
b58abc7 to
68794c4
Compare
jkowalleck
changed the title
jkowalleck
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
This is a draft, an idea.
The philosophy/contract of this library, i it's early days, was to auto-populate all bom-refs,
so the JSON/XML result after deserializarion might be Bom-Link-able out of the box.
Over the years, some new bom-refs were introduced, and did no longer auto-populatd (maybe they were forgotten? maybe on purpose to prevent breaking changes?)
This PR is a fix to follow that contract, again.
BREAKING change
TODO / DONE
BomRefDiscriminator.from_bom()PostalAddressRequirementLevelStandard